Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not require cluster id to exist for image #600

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Do not require cluster id to exist for image #600

merged 1 commit into from
Nov 15, 2023

Conversation

oscarlorentzon
Copy link
Member

Motivation

Cluster may be missing, do not throw fatal error but be more resilient.

Contribution

  • Warn instead of throwing when cluster is not set on image.

Test Plan

yarn test
yarn start

@oscarlorentzon oscarlorentzon added this to the v5.0.0 milestone Nov 15, 2023
@oscarlorentzon oscarlorentzon self-assigned this Nov 15, 2023
@oscarlorentzon oscarlorentzon merged commit bf54640 into main Nov 15, 2023
5 checks passed
@oscarlorentzon oscarlorentzon deleted the feature-cluster-id branch November 15, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oscarlorentzon oscarlorentzon

Labels
cla signed
Projects
None yet
Milestone
v5.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@oscarlorentzon @facebook-github-bot