[SSDK-544] Replace supportSBS binary with expandable ApiType enum #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
previously approved these changes
Jan 26, 2024
| case .geocoding: | ||
| return .geocoding | ||
| case .SBS: | ||
| return .SBS |
There was a problem hiding this comment.
what is the significance of the "." in ".SBS"?
There was a problem hiding this comment.
Just Swift syntax for referencing an enum case, and the type of the enum is inferred from the return value of the function's signature.
ghost
approved these changes
Feb 5, 2024
aokj4ck
added a commit
that referenced
this pull request
Mar 20, 2024
…h arguments com.mapbox.mapboxsearch.enableSBS - Removed in beta.33 - More thoroughly parameterized in 2.0.0-rc.2 / SSDK-544 / PR #162
aokj4ck
added a commit
that referenced
this pull request
Mar 20, 2024
…h arguments com.mapbox.mapboxsearch.enableSBS (#195) ### Description - Removed in beta.33 - More thoroughly parameterized in 2.0.0-rc.2 / SSDK-544 / PR #162 #### Screenshots | Before | After | | -- | -- | | <img width="1254" alt="Screenshot 2024-03-20 at 13 47 09" src="https://github.com/mapbox/mapbox-search-ios/assets/384288/ddd96362-00d9-4dba-b08a-697be1389124"> | <img width="1254" alt="Screenshot 2024-03-20 at 13 46 21" src="https://github.com/mapbox/mapbox-search-ios/assets/384288/86be713e-5d44-4fe2-bca7-c102ba78a0d6"> |
aokj4ck
added a commit
that referenced
this pull request
Apr 5, 2024
…h arguments com.mapbox.mapboxsearch.enableSBS (#195) ### Description - Removed in beta.33 - More thoroughly parameterized in 2.0.0-rc.2 / SSDK-544 / PR #162 #### Screenshots | Before | After | | -- | -- | | <img width="1254" alt="Screenshot 2024-03-20 at 13 47 09" src="https://github.com/mapbox/mapbox-search-ios/assets/384288/ddd96362-00d9-4dba-b08a-697be1389124"> | <img width="1254" alt="Screenshot 2024-03-20 at 13 46 21" src="https://github.com/mapbox/mapbox-search-ios/assets/384288/86be713e-5d44-4fe2-bca7-c102ba78a0d6"> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes SSDK-544
supportSBS: Bool = falseparameter toapiType: ApiType = .SBS.Checklist
CHANGELOG