[Android Auto] Start declaring apis with java interop #6292
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,83 @@ | ||
| package com.mapbox.navigation.qa_test_app.testing; | ||
|
|
||
| import androidx.annotation.NonNull; | ||
| import androidx.car.app.CarContext; | ||
| import androidx.lifecycle.LifecycleOwner; | ||
|
|
||
| import com.mapbox.androidauto.MapboxCarNavigationManager; | ||
| import com.mapbox.androidauto.internal.car.search.CarPlaceSearch; | ||
| import com.mapbox.maps.extension.androidauto.MapboxCarMap; | ||
| import com.mapbox.navigation.base.options.NavigationOptions; | ||
| import com.mapbox.navigation.core.MapboxNavigation; | ||
| import com.mapbox.navigation.core.lifecycle.MapboxNavigationApp; | ||
| import com.mapbox.navigation.core.lifecycle.MapboxNavigationObserver; | ||
|
|
||
| import java.util.List; | ||
|
|
||
| import kotlinx.coroutines.CoroutineScope; | ||
|
|
||
| class CarJavaInterfaceChecker { | ||
|
|
||
| void MapboxNavigationApp( | ||
| LifecycleOwner lifecycleOwner, | ||
| NavigationOptions navigationOptions, | ||
| MapboxNavigationObserver observer | ||
| ) { | ||
| // Set up now | ||
| MapboxNavigationApp.setup(navigationOptions); | ||
|
|
||
| // Set up provider | ||
| MapboxNavigationApp.setup(() -> navigationOptions); | ||
|
|
||
| // Control lifecycles | ||
| MapboxNavigationApp.attach(lifecycleOwner); | ||
| MapboxNavigationApp.disable(); | ||
| MapboxNavigationApp.detach(lifecycleOwner); | ||
|
|
||
| // Get current instance | ||
| MapboxNavigation mapboxNavigation = MapboxNavigationApp.current(); | ||
|
|
||
| // Register and unregister observer | ||
| MapboxNavigationApp.registerObserver(observer); | ||
| MapboxNavigationApp.unregisterObserver(observer); | ||
|
|
||
| MapboxNavigationObserver otherObserver = MapboxNavigationApp.getObserver(CarPlaceSearch.class); | ||
| List<CarPlaceSearch> otherObservers = MapboxNavigationApp.getObservers(CarPlaceSearch.class); | ||
| } | ||
|
|
||
| void MapboxNavigationObserver() { | ||
| MapboxNavigationObserver observer = new MapboxNavigationObserver() { | ||
| @Override | ||
| public void onAttached(@NonNull MapboxNavigation mapboxNavigation) { | ||
|
|
||
| } | ||
|
|
||
| @Override | ||
| public void onDetached(@NonNull MapboxNavigation mapboxNavigation) { | ||
|
|
||
| } | ||
| }; | ||
| } | ||
|
|
||
| void MapboxCarNavigationManager( | ||
| CarContext carContext, | ||
| LifecycleOwner lifecycleOwner, | ||
| MapboxCarMap mapboxCarMap | ||
| ) { | ||
| // Constructor | ||
| MapboxCarNavigationManager sut = new MapboxCarNavigationManager(carContext); | ||
|
|
||
| // Observing auto drive | ||
| CoroutineScope scope = JavaFlow.lifecycleScope(lifecycleOwner); | ||
| JavaFlow.collect(sut.getAutoDriveEnabledFlow(), scope, (enabled) -> { | ||
| // check enabled | ||
| }); | ||
|
|
||
| // Get auto drive value | ||
| boolean isEnabled = sut.getAutoDriveEnabledFlow().getValue(); | ||
|
|
||
| // Register onto MapboxNavigationAPp | ||
| MapboxNavigationApp.registerObserver(sut); | ||
| MapboxNavigationApp.unregisterObserver(sut); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| package com.mapbox.navigation.qa_test_app.testing | ||
|
|
||
| import androidx.lifecycle.LifecycleOwner | ||
| import androidx.lifecycle.lifecycleScope | ||
| import kotlinx.coroutines.CoroutineScope | ||
| import kotlinx.coroutines.flow.Flow | ||
| import kotlinx.coroutines.flow.collect | ||
| import kotlinx.coroutines.launch | ||
|
|
||
| /** | ||
| * This is not production tested. It is used to showcase java interoperability. | ||
| */ | ||
| object JavaFlow { | ||
|
|
||
| @JvmStatic | ||
| fun lifecycleScope(owner: LifecycleOwner): CoroutineScope = owner.lifecycleScope | ||
|
|
||
| @JvmStatic | ||
| fun <T> collect(flow: Flow<T>, scope: CoroutineScope, consumer: Consumer<T>) { | ||
| scope.launch { | ||
| flow.collect { value -> consumer.accept(value) } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| interface Consumer<T> { | ||
|
There was a problem hiding this comment. There is There was a problem hiding this comment. Didn't use it because it requires api 24
|
||
| fun accept(value: T) | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we automate checks if any of public objects' functions or public static functions don't have java interrupt @kmadsen ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm I don't know I just lost some confidence in the @JvmStatic https://mapbox.atlassian.net/browse/NAVSDK-544
https://issuetracker.google.com/issues/158393309
It changes the method signature so any changes will risk SEMVER
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2.8 is the first stable version for
MapboxNavigationAppso this could be fine. But for other functions that have had previous stable versions - it will change the method signature.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The crash looks like it should be fixed by #6316.