Make MapboxNavigationApp.setup create new instance #6288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmadsen
force-pushed
the
km-make-setup-create-new-instance
branch
from
765ea8a to
ba07b01
Compare
|
Note that Android Auto still has issues with each example in the phone re-creating different versions of MapboxNavigation. Those issues will be resolved by this #6141 |
Codecov Report
@@ Coverage Diff @@
## main #6288 +/- ##
============================================
- Coverage 68.83% 68.82% -0.01%
Complexity 4414 4414
============================================
Files 663 663
Lines 26493 26490 -3
Branches 3111 3111
============================================
- Hits 18236 18233 -3
Misses 7075 7075
Partials 1182 1182
|
kmadsen
force-pushed
the
km-make-setup-create-new-instance
branch
from
ba07b01 to
830cae8
Compare
kmadsen
force-pushed
the
km-make-setup-create-new-instance
branch
from
830cae8 to
0d9ae0e
Compare
Zayankovsky
approved these changes
Sep 8, 2022
|
static-analysis failed with the same issue i'm finding over here #6234 (comment) |
kmadsen
force-pushed
the
km-make-setup-create-new-instance
branch
from
c16510c to
4406ce4
Compare
kmadsen
commented
Sep 8, 2022
| @@ -598,6 +598,7 @@ jobs: | |||
|
|
|||
| static-analysis: | |||
| executor: ndk-r22-latest-executor | |||
| resource_class: medium+ | |||
There was a problem hiding this comment.
Have been running out of memory specifically with the Run android lint job
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have been discussing an issue where the examples need to call
disableto have their newNavigationOptionsaccepted by theMapboxNavigationAppMapboxNavigationProvidertoMapboxNavigationAppmapbox-navigation-android-examples#129 (comment)MapboxNavigationcalledrequireMapboxNavigation#6233 (comment)The solution was to add a disable into the "orchestrating" activity. Which is the MainActivity that helps you select different examples.
The problem with that is that it breaks Android Auto while you're selecting an example. The whole point of this is to make the examples work well with Android Auto.
Why this new solution is being considered desirable, is because there is a
MapboxNavigationApp.isSetupfunction available. If you really do not want to trigger a recreation, that option is available. The new setup function puts more trust into the caller that they know setup will trigger a new instance ofMapboxNavigation.