Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding nightclub icon #589

Merged
merged 2 commits into from
Mar 1, 2024
Merged

Adding nightclub icon #589

merged 2 commits into from
Mar 1, 2024

Conversation

Udobnyj
Copy link
Contributor

@Udobnyj Udobnyj commented Jan 30, 2024

@tristen
Copy link
Member

tristen commented Jan 30, 2024

@Udobnyj the legibility here is hard to make out.

Screenshot 2024-01-30 at 12 48 11 PM
  1. The stars are proportionally similar to the head which makes them hard to distinguish.
  2. The left arm is too close to the body making it slightly hard to distinguish a body

Also, I wonder if this icon should conform merely closely to existing person in motion Maki icons:

Screenshot 2024-01-30 at 12 47 46 PM
  1. Equal sized head
  2. Angular lines that follow the pixel grid

@Udobnyj
Copy link
Contributor Author

Udobnyj commented Jan 30, 2024

Hey @tristen ,
Thanks a lot for your feedback!

I totally agree with you about the legibility issues and your points on the stars and hands.
I'll brainstorm some solutions for those tomorrow.

Regarding the Maki icons, I've got a few thoughts. I'm currently updating them on an optional basis and, after analyzing them, I've noticed that our people icons aren't as consistent as they might appear.
Take the head size, for example;
Screenshot 2024-01-30 at 20 33 20

Also, the pixel align and rounded corners vary across the icons.

As I'm working on a new approach for Maki, I'm aiming for a smoother and more uniform style. So, I thought it would be best to design the new icon in this style as part of a gradual update.
Screenshot 2024-01-30 at 20 33 31

I see your point, though. Perhaps I need to tone down my icon a bit to prevent it from standing out too much for now.

Plus, I wanted to revisit a question we discussed about a year ago:
Do we still need to adhere to the pixel-align rule?
With screen resolutions these days, pixel visibility isn't really an issue anymore. 😓

@tristen
Copy link
Member

tristen commented Feb 1, 2024

@Udobnyj I like the new approach you are taking to the icons! Excited to see this develop

Do we still need to adhere to the pixel-align rule?

I still think pixel alignment is important. Maki icons are rendered at 15px x 15px as PNGs. Pixel alignment helps to prevent poor results from anti-aliasing. But there's totally room to deviate from this (many of the icons do). As long as things look legible at 100% screen resolution under different scenarios (white/black against POI background colors) we're good 👍

@Udobnyj
Copy link
Contributor Author

Udobnyj commented Feb 12, 2024

Hey guys @tristen @aokj4ck , I got a bit swamped with some other tasks that were more pressing, but I'm back now. I've sketched out three quick concepts for the icon and would love to hear your thoughts.

Screenshot 2024-02-12 at 18 00 05

@aokj4ck
Copy link

aokj4ck commented Feb 12, 2024

I do think the CD is too far removed from a nightclub conceptually. Other than that LGTM whatever you and Tristan align on.

@tristen
Copy link
Member

tristen commented Feb 12, 2024

Nice @Udobnyj! Personally, I love the direction of the last one

@Udobnyj
Copy link
Contributor Author

Udobnyj commented Feb 13, 2024

Thanks for the feedback!

@aokj4ck damn :) I tried to draw vinyl, but it seemed like it didn't work out.
@tristen Thanks; I'll be back with the results.

@Udobnyj
Copy link
Contributor Author

Udobnyj commented Feb 29, 2024

Hey guys, one more time 🙏
@tristen @aokj4ck

Updated last option
Screenshot 2024-02-29 at 12 18 10

In the app preview
Screenshot 2024-02-29 at 12 17 17

On the map preview
Screenshot 2024-02-29 at 12 20 48

Map to check
https://api.mapbox.com/styles/v1/udobnyi/clruuymhq00p901qy0ud47roi.html?title=view&access_token=pk.eyJ1IjoidWRvYm55aSIsImEiOiJja3liZGU0NzMwZTlhMnBvOHFuOWxlNmYxIn0.mhFm05xmSMi6w28_1fvxVg&zoomwheel=true&fresh=true#17.1/40.716454/-73.994289

@aokj4ck
Copy link

aokj4ck commented Feb 29, 2024

I love it and that's gonna be my next tattoo

@Udobnyj Udobnyj merged commit 7e87952 into main Mar 1, 2024
2 checks passed
@Udobnyj Udobnyj deleted the nightclub branch March 1, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants