Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DX: getRepository with wrong name should help the developper finding the best key #145

Merged
merged 2 commits into from
Aug 29, 2024

Conversation

jdeniau
Copy link
Member

@jdeniau jdeniau commented Aug 29, 2024

When someone make a typo on the "key" used (PascalCase instead of camelCase), it is difficult to understand why the mapping is not found.

We use levenshtein distance to get the closest possible key and warn the user.

@jdeniau jdeniau requested a review from a team August 29, 2024 07:55
@jdeniau jdeniau force-pushed the mapping-name-error-dx branch from b7c6d46 to e8b21fb Compare August 29, 2024 07:58
@jdeniau jdeniau changed the title add test matching current error message DX: getRepository with wrong name should help the developper finding the best key Aug 29, 2024
@jdeniau jdeniau merged commit 503c1b2 into main Aug 29, 2024
4 checks passed
@jdeniau jdeniau deleted the mapping-name-error-dx branch August 29, 2024 12:37
Copy link
Contributor

@potlaetitia potlaetitia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Olalala mais ouiiiii! Merci! 😌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants