Merge pull request #3446 from manyfold3d/fix-update-all

Fix "update all" button
manyfold3d · Jan 20, 2025 · 09aaff6 · 09aaff6
2 parents 216a605 + c45f6ca
commit 09aaff6
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/app/controllers/models_controller.rb b/app/controllers/models_controller.rb
@@ -140,7 +140,7 @@ def bulk_update
     add_tags = Set.new(hash.delete(:add_tags))
     remove_tags = Set.new(hash.delete(:remove_tags))
 
-    models_to_update = if params[:commit] == t("models.bulk_edit.update_all")
+    models_to_update = if params.key?(:update_all)
       # If "Update All Models" was clicked, update all models in the filtered set
       filtered_models(@filters)
     else

diff --git a/app/views/models/bulk_edit.html.erb b/app/views/models/bulk_edit.html.erb
@@ -58,7 +58,7 @@
       <%= form.hidden_field :library, value: @filters[:library] if @filters[:library] %>
       <%= form.hidden_field :creator, value: @filters[:creator] if @filters[:creator] %>
       <%= form.submit translate(".submit"), class: "btn btn-primary" %>
-      <%= form.submit translate(".update_all", count: @models.total_count), class: "btn btn-secondary" %>
+      <%= form.submit translate(".update_all", count: @models.total_count), class: "btn btn-secondary", name: "update_all" %>
 
     </div>
     <% if !@filters.empty? %>

diff --git a/spec/requests/models_spec.rb b/spec/requests/models_spec.rb
@@ -215,7 +215,7 @@
 
         let(:params) do
           {
-            commit: I18n.t("models.bulk_edit.update_all"),
+            update_all: I18n.t("models.bulk_edit.update_all"),
             new_library_id: new_library.id,
             tag: [tag.name]
           }