Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic container packaging #9

Merged
merged 6 commits into from
Jul 1, 2024
Merged

Add basic container packaging #9

merged 6 commits into from
Jul 1, 2024

Conversation

gsaslis
Copy link
Collaborator

@gsaslis gsaslis commented May 13, 2024

This adds basic packaging in a container image.

Copy link

netlify bot commented May 13, 2024

Deploy Preview for guileless-puppy-2d91b5 ready!

Name Link
🔨 Latest commit 09d203d
🔍 Latest deploy log https://app.netlify.com/sites/guileless-puppy-2d91b5/deploys/6682d91fc0250900087acc1d
😎 Deploy Preview https://deploy-preview-9--guileless-puppy-2d91b5.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@gsaslis gsaslis changed the title Add basic container packaging [WIP] Add basic container packaging May 22, 2024
@gsaslis gsaslis marked this pull request as draft May 22, 2024 10:51
gsaslis added 5 commits June 28, 2024 17:53
with a sample docker-compose deployment option

Signed-off-by: Yorgos Saslis <yorgos.work@proton.me>
- better to start simple here and add caching, etc. later, in production scenarios
- fixes caddyfile formatting

Signed-off-by: Yorgos Saslis <yorgos.work@proton.me>
the compose packaging serves as an example of how to deploy the image and is not meant as a production deployment example.

Signed-off-by: Yorgos Saslis <yorgos.work@proton.me>
this allows to run the compose using the pre-built image

Signed-off-by: Yorgos Saslis <yorgos.work@proton.me>
Signed-off-by: Yorgos Saslis <yorgos.work@proton.me>
@gsaslis gsaslis changed the title [WIP] Add basic container packaging Add basic container packaging Jul 1, 2024
@gsaslis gsaslis marked this pull request as ready for review July 1, 2024 12:52
Copy link
Collaborator

@QZera QZera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not much to say on my side if you've tested this locally. LGTM

the one in radicle-in-containers

Signed-off-by: Yorgos Saslis <yorgos.work@proton.me>
try_files {path} /index.html
file_server
#header @static Cache-Control "public, max-age=259200"
#encode zstd gzip
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no reason not to enable gzip compression.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it necessary in a local-first, dev env?

@gsaslis gsaslis merged commit 553e5de into master Jul 1, 2024
12 of 13 checks passed
@gsaslis gsaslis deleted the containerize branch July 1, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants