-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic container packaging #9
Conversation
✅ Deploy Preview for guileless-puppy-2d91b5 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
with a sample docker-compose deployment option Signed-off-by: Yorgos Saslis <yorgos.work@proton.me>
- better to start simple here and add caching, etc. later, in production scenarios - fixes caddyfile formatting Signed-off-by: Yorgos Saslis <yorgos.work@proton.me>
the compose packaging serves as an example of how to deploy the image and is not meant as a production deployment example. Signed-off-by: Yorgos Saslis <yorgos.work@proton.me>
this allows to run the compose using the pre-built image Signed-off-by: Yorgos Saslis <yorgos.work@proton.me>
Signed-off-by: Yorgos Saslis <yorgos.work@proton.me>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not much to say on my side if you've tested this locally. LGTM
the one in radicle-in-containers Signed-off-by: Yorgos Saslis <yorgos.work@proton.me>
try_files {path} /index.html | ||
file_server | ||
#header @static Cache-Control "public, max-age=259200" | ||
#encode zstd gzip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see no reason not to enable gzip compression.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it necessary in a local-first, dev env?
This adds basic packaging in a container image.