Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump the linux standalone build to use python 3.13 #2594 #2595

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

dhruvak001
Copy link
Contributor

@dhruvak001 dhruvak001 commented Feb 5, 2025

Fixes #2594

[x] No CHANGELOG update needed
[x] No new tests needed
[x] No documentation update needed

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add bug fixes, new features, breaking changes and anything else you think is worthwhile mentioning to the master (unreleased) section of CHANGELOG.md. If no CHANGELOG update is needed add the following to the PR description: [x] No CHANGELOG update needed

@github-actions github-actions bot dismissed their stale review February 5, 2025 19:13

CHANGELOG updated or no update needed, thanks! 😄

@dhruvak001 dhruvak001 closed this Feb 5, 2025
@dhruvak001 dhruvak001 reopened this Feb 5, 2025
@v1bh475u
Copy link
Contributor

v1bh475u commented Feb 5, 2025

@dhruvak001, I already working on this issue. Please pick some other issue.

@dhruvak001
Copy link
Contributor Author

@v1bh475u oh okay! you can check the changes if it may help.

@dhruvak001
Copy link
Contributor Author

@v1bh475u btw this #2595 now passes "build / PyInstaller for ubuntu-20.04 / Py 3.13 (pull_request)" Action.

@williballenthin is this all for this issue or it needs more updates (@v1bh475u)

@williballenthin
Copy link
Collaborator

please remove the changes to the IDA plugin and do not increase the minimum required Python version. this PR should be totally focused on only the standalone binary build.

@dhruvak001
Copy link
Contributor Author

@williballenthin do this FAILED tests/test_main.py::test_main_dotnet needed to be rectified?

@williballenthin
Copy link
Collaborator

do they have anything to do with the changes you made? you should be able to confirm locally.

@dhruvak001
Copy link
Contributor Author

@williballenthin locally testing this FAILED tests/test_main.py::test_main_dotnet passed for me. The error here is coming from .NET files which comes for testing from submodules tests/data https://github.com/mandiant/capa-testfiles/tree/6cf615dd014de8b1979d2619d7f832b4133bfa11

@williballenthin
Copy link
Collaborator

are you running on the latest master? make sure you've updated your branch please.

@dhruvak001
Copy link
Contributor Author

@williballenthin the test failing here in Github actions seems to be some other issue! can please you check this Dotnet Test Failure

@williballenthin
Copy link
Collaborator

so you are not able to reproduce the problem locally?

@dhruvak001
Copy link
Contributor Author

@williballenthin yeah, even with the latest master.

@dhruvak001 dhruvak001 closed this Feb 11, 2025
@dhruvak001 dhruvak001 reopened this Feb 11, 2025
@dhruvak001
Copy link
Contributor Author

@williballenthin can you please review it?

Copy link
Collaborator

@williballenthin williballenthin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there seem to be a bunch of unrelated changes. please revert those. the asset_name and python_version changes look good, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bump the linux standalone build to use python 3.13
3 participants