-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump the linux standalone build to use python 3.13 #2594 #2595
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add bug fixes, new features, breaking changes and anything else you think is worthwhile mentioning to the master (unreleased)
section of CHANGELOG.md. If no CHANGELOG update is needed add the following to the PR description: [x] No CHANGELOG update needed
CHANGELOG updated or no update needed, thanks! 😄
@dhruvak001, I already working on this issue. Please pick some other issue. |
@v1bh475u oh okay! you can check the changes if it may help. |
@v1bh475u btw this #2595 now passes "build / PyInstaller for ubuntu-20.04 / Py 3.13 (pull_request)" Action. @williballenthin is this all for this issue or it needs more updates (@v1bh475u) |
please remove the changes to the IDA plugin and do not increase the minimum required Python version. this PR should be totally focused on only the standalone binary build. |
@williballenthin do this FAILED tests/test_main.py::test_main_dotnet needed to be rectified? |
do they have anything to do with the changes you made? you should be able to confirm locally. |
@williballenthin locally testing this FAILED tests/test_main.py::test_main_dotnet passed for me. The error here is coming from .NET files which comes for testing from submodules tests/data https://github.com/mandiant/capa-testfiles/tree/6cf615dd014de8b1979d2619d7f832b4133bfa11 |
are you running on the latest master? make sure you've updated your branch please. |
@williballenthin the test failing here in Github actions seems to be some other issue! can please you check this Dotnet Test Failure |
so you are not able to reproduce the problem locally? |
@williballenthin yeah, even with the latest master. |
@williballenthin can you please review it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there seem to be a bunch of unrelated changes. please revert those. the asset_name and python_version changes look good, though.
Fixes #2594
[x] No CHANGELOG update needed
[x] No new tests needed
[x] No documentation update needed