Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parsing problem #14

Open
EJHyun opened this issue Jan 17, 2022 · 1 comment
Open

parsing problem #14

EJHyun opened this issue Jan 17, 2022 · 1 comment

Comments

@EJHyun
Copy link

EJHyun commented Jan 17, 2022

Hi thanks for the code.
But I found some problematic part in your code

in
time_proj.py
in def load_data()
there is this code snippet

with open(self.p.dataset,'r') as filein:
	for line in filein:
		train_triples.append([int(x.strip()) for x in line.split()[0:3]])
		triple_time[count] = [x.split('-')[0] for x in line.split()[3:5]] 
		count+=1

self.p.dataset means the trainset of data.
and the line

triple_time[count] = [x.split('-')[0] for x in line.split()[3:5]] 

splits time interval part with '-'
but inside YAGO's dataset, there is fact like this
image
And this fact's start time will be parsed like this
image

It seems problematic to me...
Isn't it???

@StarAx0519
Copy link

I think it is really a problem, I can't understand, too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants