From f2da8469e573558bf4b589eee62b543da83062da Mon Sep 17 00:00:00 2001
From: malkiAbdoo <abdo.malkiep@gmail.com>
Date: Sat, 4 Nov 2023 22:42:36 +0100
Subject: [PATCH] fix: update the default values

---
 package/src/useMediaDevices/index.ts  | 2 +-
 package/src/useMediaRecorder/index.ts | 7 ++++---
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/package/src/useMediaDevices/index.ts b/package/src/useMediaDevices/index.ts
index 4031ca5..6b312c3 100644
--- a/package/src/useMediaDevices/index.ts
+++ b/package/src/useMediaDevices/index.ts
@@ -9,7 +9,7 @@ export type MediaDevicesOptions = MediaStreamConstraints & {
 };
 
 export const useMediaDevices = (options: MediaDevicesOptions = {}) => {
-  const { ref, startOnMount = true, ...globalConstraints } = options;
+  const { ref, startOnMount = false, ...globalConstraints } = options;
 
   const videoRef = useNewRef<HTMLVideoElement>(options.ref);
   const streamRef = useRef<MediaStream>(new MediaStream());
diff --git a/package/src/useMediaRecorder/index.ts b/package/src/useMediaRecorder/index.ts
index c7428f4..7adc6f3 100644
--- a/package/src/useMediaRecorder/index.ts
+++ b/package/src/useMediaRecorder/index.ts
@@ -17,7 +17,8 @@ export const useMediaRecorder = (options: MediaRecorderOptions = {}) => {
   const controls = useMemo(
     () => ({
       start(stream: MediaStream, timeslice?: number) {
-        if (recorderRef.current?.state !== 'inactive') return;
+        const state = recorderRef.current?.state ?? 'inactive';
+        if (state !== 'inactive') return;
 
         recorderRef.current = new MediaRecorder(stream, options);
         recorderRef.current.ondataavailable = event => {
@@ -37,7 +38,8 @@ export const useMediaRecorder = (options: MediaRecorderOptions = {}) => {
         }
       },
       async stop(options: RecorderDownloadOptions = {}) {
-        if (recorderRef.current?.state == 'inactive') return;
+        const state = recorderRef.current?.state ?? 'inactive';
+        if (state === 'inactive') return;
         recorderRef.current?.resume();
         recorderRef.current?.stop();
 
@@ -51,7 +53,6 @@ export const useMediaRecorder = (options: MediaRecorderOptions = {}) => {
         return blob;
       },
       togglePlayState(play?: boolean) {
-        if (recorderRef.current?.state == 'inactive') return;
         const shouldPlay = play ?? recorderRef.current?.state == 'paused';
         shouldPlay ? this.resume() : this.pause();
       },