fix: update the default values

malkiii · Nov 4, 2023 · f2da846 · f2da846
1 parent e08c6e4
commit f2da846
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/package/src/useMediaDevices/index.ts b/package/src/useMediaDevices/index.ts
@@ -9,7 +9,7 @@ export type MediaDevicesOptions = MediaStreamConstraints & {
 };
 
 export const useMediaDevices = (options: MediaDevicesOptions = {}) => {
-  const { ref, startOnMount = true, ...globalConstraints } = options;
+  const { ref, startOnMount = false, ...globalConstraints } = options;
 
   const videoRef = useNewRef<HTMLVideoElement>(options.ref);
   const streamRef = useRef<MediaStream>(new MediaStream());

diff --git a/package/src/useMediaRecorder/index.ts b/package/src/useMediaRecorder/index.ts
@@ -17,7 +17,8 @@ export const useMediaRecorder = (options: MediaRecorderOptions = {}) => {
   const controls = useMemo(
     () => ({
       start(stream: MediaStream, timeslice?: number) {
-        if (recorderRef.current?.state !== 'inactive') return;
+        const state = recorderRef.current?.state ?? 'inactive';
+        if (state !== 'inactive') return;
 
         recorderRef.current = new MediaRecorder(stream, options);
         recorderRef.current.ondataavailable = event => {
@@ -37,7 +38,8 @@ export const useMediaRecorder = (options: MediaRecorderOptions = {}) => {
         }
       },
       async stop(options: RecorderDownloadOptions = {}) {
-        if (recorderRef.current?.state == 'inactive') return;
+        const state = recorderRef.current?.state ?? 'inactive';
+        if (state === 'inactive') return;
         recorderRef.current?.resume();
         recorderRef.current?.stop();
 
@@ -51,7 +53,6 @@ export const useMediaRecorder = (options: MediaRecorderOptions = {}) => {
         return blob;
       },
       togglePlayState(play?: boolean) {
-        if (recorderRef.current?.state == 'inactive') return;
         const shouldPlay = play ?? recorderRef.current?.state == 'paused';
         shouldPlay ? this.resume() : this.pause();
       },