Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kmbarry1 review comments #2

Closed
kmbarry1 opened this issue May 13, 2021 · 1 comment
Closed

kmbarry1 review comments #2

kmbarry1 opened this issue May 13, 2021 · 1 comment

Comments

@kmbarry1
Copy link
Collaborator

We usually name mappings after their values, not their keys, and we usually use the singular, so I'd suggest renaming delegators to stake or something similar.

Other than that...just the ongoing concern about delegation being potentially everlasting, which #1 is addressing.
@gbalabasquer
Copy link
Contributor

This was fixed in this PR: #3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kmbarry1 @gbalabasquer