Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multiple Kogan devices #2882

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

Mantrid42
Copy link

These devices have all been tested to work with my Kogan devices. Some caveats:

  1. I'm ignoring the bitfield reporting for air_quality (125) since it reports data; mostly to see if it ever changes
  2. Ignoring the bitfield reporting for left_right_freeze (127) because the bitfield says it's not supported but it definitely is and works
  3. I barely have any "optional" tags, so the feature set would have to match exactly
  4. I don't have any "hidden: unavailable" tags because they never get hidden when adding the devices

These devices have all been tested to work with my Kogan devices.
Some caveats:
1. I'm ignoring the bitfield reporting for air_quality (125) since it reports data; mostly to see if it ever changes
2. Ignoring the bitfield reporting for left_right_freeze (127) because the bitfield says it's not supported but it definitely is and works
3. I barely have any "optional" tags, so the feature set would have to match exactly
4. I don't have any "hidden: unavailable" tags because they never get hidden when adding the devices
@make-all
Copy link
Owner

It would be better to split these into individual PRs. The smartplug configs seem identical to existing configs, and both air conditioners seem to be broadly compatible with the fisher_summer config, but I haven't looked into the details like presets available. Quite likely the air purifier is an easy addition, the vacuum is very close to both the lx8 and lx10 and possibly could be merged with one of them, or the liectrex model that is also very close.

@Mantrid42
Copy link
Author

Sorry, I'm still a newbie with this stuff. The fisher_summer config is missing a bunch of things, and has things that don't work. I can do separate pull requests if you'd like, and add comments for what's different or otherwise why I made a custom config. The IP44 switch has two outlets, and one or two of the ids were different. The other smart switch may have just been that I didn't like it adding things that don't exist, most because "hidden: unavailable" doesn't work. I figured a direct ID match would save people the same trouble.

Comparison of the same unit, with my config vs SF
8k2_compare

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 👀 In review
Development

Successfully merging this pull request may close these issues.

2 participants