Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing panels in generated report for large dashboard #206

Open
soursing opened this issue Dec 16, 2024 · 12 comments
Open

Missing panels in generated report for large dashboard #206

soursing opened this issue Dec 16, 2024 · 12 comments
Labels

Comments

@soursing
Copy link

soursing commented Dec 16, 2024

Hi,

When generating reports for dashboard with multiple panels (more than 20), some panels are not included in report.
It shows blank space for the missing panels.

We're not excluding any panels from report link (/api/plugins/mahendrapaipuri-dashboardreporter-app/resources/report?dashUid=UID of dashboard). Also no error is seen on grafana logs.

Grafana Version: 11.3.0
Plugin Version: 1.7.0

@mahendrapaipuri
Copy link
Owner

Could you please share the logs? The panels are rendered using grafana-image-renderer and I assume it is returning empty PNGs.

@soursing
Copy link
Author

Attached logs: pdf-reporting.log.

And always the same panels are missed in the report.

@mahendrapaipuri
Copy link
Owner

Thanks for the logs.

Could you tell me the IDs of the panels that are missing in the report? Are missing panels in a collapsed row? If so, you need to use dashboardMode=full in query parameters or plugin settings in the UI to render those panels

@soursing
Copy link
Author

Missed panel is not in part of collapsed row.
Panel ID 44 is missed, same panel is still missed when using dashboardMode=full.

@mahendrapaipuri
Copy link
Owner

Is is possible to share your dashboard JSON model after removing any sensitive info you have? If not can you try with nightly version?

Cheers

@soursing
Copy link
Author

I tried to generated report for the test dashboard, with dashboardMode=full and nightly version, but still panels with id 6 and 18 are missing from report.

I've similar setup as docker-compose.

@mahendrapaipuri
Copy link
Owner

Whcih OS are you using? And how did you install chromium? Could you try using chromium in a container?

@soursing
Copy link
Author

I'm running on Ubuntu 22.04, and running chromium, grafana, grafana-image-renderer as docker container as suggested in docker-compose.yaml.

@mahendrapaipuri
Copy link
Owner

@soursing Yes, I can reproduce the behaviour with the test dashboard. Thanks a lot for testing. I will look into it.

@mahendrapaipuri
Copy link
Owner

@soursing I pushed a fix to the main. Could you please re-install nightly release and see if it fixes on your dashboard? Cheers

@soursing
Copy link
Author

Thanks a lot for checking and providing a fix. However I agree with the comment that this fix could be improved.

Instead of hardcoding the view height to a large number, it would be better to find a proper fix so it can load the panels even if height of dashboard is larger than the hardcoded value.

@mahendrapaipuri
Copy link
Owner

Thanks a lot for testing @soursing

The issue is that we need to first get the total window height when all panels are expanded and use that to set view port height to get the panel data. Basically that translates to executing the same JS twice with and without view port set.

Anyways I find it is strange having to set view port height to fetch entire dashboard. It all started with Grafana v11.3 where dashboards are lazily loaded. I need to look into their frontend code to understand what is happening.

For the instant, I will make a hotfix release and I will look more into it bit later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants