Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set follow_redirects=True #32

Merged
merged 1 commit into from
Jan 20, 2025
Merged

set follow_redirects=True #32

merged 1 commit into from
Jan 20, 2025

Conversation

magicxor
Copy link
Owner

No description provided.

@magicxor magicxor self-assigned this Jan 20, 2025
@magicxor magicxor added the bug Something isn't working label Jan 20, 2025
@magicxor magicxor merged commit 8fa02f2 into master Jan 20, 2025
1 check passed
@magicxor magicxor deleted the fix/follow_redirects branch January 20, 2025 03:39
@magicxor
Copy link
Owner Author

@CodiumAI-Agent /review

@CodiumAI-Agent
Copy link

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Follow Redirects Behavior

The addition of follow_redirects=True in the httpx.AsyncClient instantiation changes the behavior of HTTP requests. Ensure that this change is intentional and does not introduce unintended consequences, such as following malicious redirects.

async with httpx.AsyncClient(follow_redirects=True) as client:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@magicxor magicxor

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@magicxor @CodiumAI-Agent