fix(MT.1006 and MT.1014): Correctly handle empty includeUsers collection in policy conditions #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PTMohr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Policy Conditions Bug
This pull request fixes a bug in the policy conditions logic where an empty
includeUserscollection would incorrectly returnfalsewhen checking if'All'is not included.The bug was caused by the use of the
-neoperator, which filters out the right-hand side of the comparison and returns the rest of the collection. When the collection is empty, this would return an empty collection, which is always consideredfalse.By changing the comparison to use the
-notcontainsoperator, we ensure that the check always returns a boolean value, correctly handling the case where theincludeUserscollection is empty.Changes:
-newith-notcontainsin policy conditions logic