Update Test-MtConditionalAccessWhatIf.ps1 #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Added DeviceInfo, InsiderRiskLevel,ServicePrincipalRiskLevel params -Added IncludeReportOnly,IncludeDisabled,PrettyJsonVerboseOutput switches -Using Test-MgBetaIdentityConditionalAccess cmdlet -Some Verbose logging
Update Test-MtConditionalAccessWhatIf.ps1
merill
approved these changes
Dec 7, 2024
There was a problem hiding this comment.
@milanschwartz Thanks a lot for your patience!
This is an excellent PR with lots of code samples and nicely done.
I did make one minor edit. In Maester we avoid dependencies of Graph PS cmdlets and instead prefer invoking the REST API directly with Invoke-Mg / Invoke-MtGraphRequest.
This way we don't need to deal with dependencies and changes to the PowerShell module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Added DeviceInfo, InsiderRiskLevel,ServicePrincipalRiskLevel params
-Added IncludeReportOnly,IncludeDisabled,PrettyJsonVerboseOutput switches
-Using Test-MgBetaIdentityConditionalAccess cmdlet
-Some Verbose logging