Fixed CIS Policy Checks #498
Merged
+44
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reconfigured checks to specifically check default policies
merill
approved these changes
Oct 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reconfigured the CIS based policy checks to specifically check the default policy. Prior to this I am not 100% what the outcome of the existing logic would have been which is an oversight. It likely only considered the first policy listed.
Checking the default policy is typically how CIS provides automated guidance. Where only the default policy is checked, it states this in the title of the output for clarity.
In the future we can probably make this better and check all policies for the desired outcome, but for now I think the clarity of the check is more important.