From 1ca6bcd08f2a5fdf1074352d9636b8350c83f67a Mon Sep 17 00:00:00 2001 From: Thomas Naunheim Date: Fri, 29 Nov 2024 19:22:21 +0100 Subject: [PATCH] Updated description of recommended value for compare operators --- build/eidsca/Update-EidscaTests.ps1 | 4 ++++ website/docs/tests/eidsca/EIDSCA.CR04.md | 2 +- website/docs/tests/eidsca/EIDSCA.PR05.md | 2 +- 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/build/eidsca/Update-EidscaTests.ps1 b/build/eidsca/Update-EidscaTests.ps1 index f112ce5b..286b45b9 100644 --- a/build/eidsca/Update-EidscaTests.ps1 +++ b/build/eidsca/Update-EidscaTests.ps1 @@ -62,6 +62,10 @@ function GetRecommendedValueMarkdown($RecommendedValueMarkdown) { if($RecommendedValueMarkdown -like "@('*,*')") { $RecommendedValueMarkdown = $RecommendedValueMarkdown -replace "@\(", "" -replace "\)", "" return "$RecommendedValueMarkdown" + } elseif ($RecommendedValueMarkdown.StartsWith(">") -or $RecommendedValueMarkdown.StartsWith("<")) { + $RecommendedValueText = (GetCompareOperator($RecommendedValueMarkdown)).Text + $RecommendedValueMarkdown = "$RecommendedValueText $RecommendedValue" + return "$RecommendedValueMarkdown" } else { return "'$RecommendedValueMarkdown'" } diff --git a/website/docs/tests/eidsca/EIDSCA.CR04.md b/website/docs/tests/eidsca/EIDSCA.CR04.md index 5a431a61..45b1c009 100644 --- a/website/docs/tests/eidsca/EIDSCA.CR04.md +++ b/website/docs/tests/eidsca/EIDSCA.CR04.md @@ -25,7 +25,7 @@ Specifies the duration the request is active before it automatically expires if | **Recommendation** | | | **Configuration** | policies/adminConsentRequestPolicy | | **Setting** | `requestDurationInDays` | -| **Recommended Value** | '<=30' | +| **Recommended Value** | is less than or equal to '30' | | **Default Value** | | | **Graph API Docs** | [adminConsentRequestPolicy resource type - Microsoft Graph v1.0 - Microsoft Learn](https://learn.microsoft.com/en-us/graph/api/resources/adminconsentrequestpolicy) | | **Graph Explorer** | [Open in Graph Explorer](https://developer.microsoft.com/en-us/graph/graph-explorer?request=policies/adminConsentRequestPolicy&method=GET&version=beta&GraphUrl=https://graph.microsoft.com) | diff --git a/website/docs/tests/eidsca/EIDSCA.PR05.md b/website/docs/tests/eidsca/EIDSCA.PR05.md index 250ceb5f..61426a4a 100644 --- a/website/docs/tests/eidsca/EIDSCA.PR05.md +++ b/website/docs/tests/eidsca/EIDSCA.PR05.md @@ -25,7 +25,7 @@ The minimum length in seconds of each lockout. If an account locks repeatedly, t | **Recommendation** | [Prevent attacks using smart lockout - Microsoft Entra ID - Microsoft Learn](https://learn.microsoft.com/en-us/azure/active-directory/authentication/howto-password-smart-lockout) | | **Configuration** | settings | | **Setting** | `values | where-object name -eq 'LockoutDurationInSeconds' | select-object -expand value` | -| **Recommended Value** | '>=60' | +| **Recommended Value** | is greater than or equal to '60' | | **Default Value** | 60 | | **Graph API Docs** | [directorySetting resource type - Microsoft Graph beta - Microsoft Learn](https://learn.microsoft.com/en-us/graph/api/resources/directorysetting) | | **Graph Explorer** | [Open in Graph Explorer](https://developer.microsoft.com/en-us/graph/graph-explorer?request=settings&method=GET&version=beta&GraphUrl=https://graph.microsoft.com) |