Skip to content

Commit

Permalink
Updated description of recommended value for compare operators
Browse files Browse the repository at this point in the history
  • Loading branch information
Cloud-Architekt committed Nov 29, 2024
1 parent da5c701 commit 1ca6bcd
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 2 deletions.
4 changes: 4 additions & 0 deletions build/eidsca/Update-EidscaTests.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,10 @@ function GetRecommendedValueMarkdown($RecommendedValueMarkdown) {
if($RecommendedValueMarkdown -like "@('*,*')") {
$RecommendedValueMarkdown = $RecommendedValueMarkdown -replace "@\(", "" -replace "\)", ""
return "$RecommendedValueMarkdown"
} elseif ($RecommendedValueMarkdown.StartsWith(">") -or $RecommendedValueMarkdown.StartsWith("<")) {
$RecommendedValueText = (GetCompareOperator($RecommendedValueMarkdown)).Text
$RecommendedValueMarkdown = "$RecommendedValueText $RecommendedValue"
return "$RecommendedValueMarkdown"
} else {
return "'$RecommendedValueMarkdown'"
}
Expand Down
2 changes: 1 addition & 1 deletion website/docs/tests/eidsca/EIDSCA.CR04.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ Specifies the duration the request is active before it automatically expires if
| **Recommendation** | |
| **Configuration** | policies/adminConsentRequestPolicy |
| **Setting** | `requestDurationInDays` |
| **Recommended Value** | '<=30' |
| **Recommended Value** | is less than or equal to '30' |
| **Default Value** | |
| **Graph API Docs** | [adminConsentRequestPolicy resource type - Microsoft Graph v1.0 - Microsoft Learn](https://learn.microsoft.com/en-us/graph/api/resources/adminconsentrequestpolicy) |
| **Graph Explorer** | [Open in Graph Explorer](https://developer.microsoft.com/en-us/graph/graph-explorer?request=policies/adminConsentRequestPolicy&method=GET&version=beta&GraphUrl=https://graph.microsoft.com) |
Expand Down
2 changes: 1 addition & 1 deletion website/docs/tests/eidsca/EIDSCA.PR05.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ The minimum length in seconds of each lockout. If an account locks repeatedly, t
| **Recommendation** | [Prevent attacks using smart lockout - Microsoft Entra ID - Microsoft Learn](https://learn.microsoft.com/en-us/azure/active-directory/authentication/howto-password-smart-lockout) |
| **Configuration** | settings |
| **Setting** | `values | where-object name -eq 'LockoutDurationInSeconds' | select-object -expand value` |
| **Recommended Value** | '>=60' |
| **Recommended Value** | is greater than or equal to '60' |
| **Default Value** | 60 |
| **Graph API Docs** | [directorySetting resource type - Microsoft Graph beta - Microsoft Learn](https://learn.microsoft.com/en-us/graph/api/resources/directorysetting) |
| **Graph Explorer** | [Open in Graph Explorer](https://developer.microsoft.com/en-us/graph/graph-explorer?request=settings&method=GET&version=beta&GraphUrl=https://graph.microsoft.com) |
Expand Down

0 comments on commit 1ca6bcd

Please sign in to comment.