Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Change the decline button wording #943

Merged
merged 3 commits into from
Jul 17, 2023
Merged

Fix: Change the decline button wording #943

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ec6605d
Merge pull request #941 from madfish-solutions/development
lourenc Jul 13, 2023
b6d868c
Remove unnecessary words from the button
lourenc Jul 17, 2023
b34d2d1
Change "no thanks" translation key
lourenc Jul 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion public/_locales/en/messages.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -993,7 +993,7 @@
},
"enableAds": { "message": "Enable Ads" },
"payMeForEveryAdISee": { "message": "Pay me for every ad I see" },
"noThanksIhateFreeMoney": { "message": "No thanks, I hate free money" },
"noThanks": { "message": "No thanks" },
"acceptAdsBannerTitle_A": {
"message": "Get paid to discover exciting services and dApps!"
},
Expand Down
4 changes: 2 additions & 2 deletions src/app/pages/Home/OtherComponents/Tokens/AcceptAdsBanner.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,9 +60,9 @@ const AcceptAdsBannerForTestGroupA: FC<Props> = ({ onEnableButtonClick, onDisabl

const disableButton: BannerButtonProps = useMemo(
() => ({
title: 'noThanksIhateFreeMoney',
title: 'noThanks',
testID: AssetsSelectors.acceptAdsBannerDisableButton,
testIDProperties: { buttonText: 'No thanks, I hate free money' },
testIDProperties: { buttonText: 'No thanks' },
onClick: onDisableButtonClick
}),
[onDisableButtonClick]
Expand Down
Loading