TW-832: NFT page re-design. Main info #931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-tsx
requested review from
herkoss,
keshan3262,
svjatoslavtt,
lendihop and
Boltman92
herkoss
reviewed
Jul 12, 2023
Comment on lines
+15
to
+29
| creators: { | ||
| holder: { | ||
| address: string; | ||
| tzdomain: string; | ||
| }; | ||
| }[]; | ||
| fa: { | ||
| name: string; | ||
| logo: string; | ||
| }; | ||
| galleries: { | ||
| gallery: { | ||
| name: string; | ||
| }; | ||
| }[]; |
There was a problem hiding this comment.
These types are not quite stable - very dependant on particular GraphQL query.
I don't want them to be accidentally reused.
keshan3262
reviewed
Jul 12, 2023
alex-tsx
force-pushed
the
TW-832-nft-page-update-main-info
branch
from
c422ace
to
70d32fc
Compare
alex-tsx
changed the base branch from
TW-760-nft-page-update
to
TW-760-epic-nft-update
keshan3262
approved these changes
Jul 12, 2023
IrynaKhyzhynska
temporarily deployed
to
development
GitHub Actions
Inactive
lourenc
added a commit
that referenced
this pull request
Sep 7, 2023
* TW-826: Collectibles re-design * TW-828: Collectibles grid layout * TW-828: Collectibles grid layout. + Scroll tabsbar into view * TW-828: Collectibles grid layout. ++ Images * TW-864: Collectibles hover effect * TW-828: Collectibles grid layout. Refactor * TW-828: Collectibles grid layout. Refactor * TW-830: Collectibles Manage dropdown. + Detailed grid * TW-830: Collectibles Manage dropdown. + Detailes toggle * TW-830: Collectibles Manage dropdown. + Floor prices * TW-828: Collectibles grid layout. Fix after QA * TW-830: Collectibles Manage dropdown. Fix floor price currency * TW-830: Collectibles Manage dropdown. Refactor * TW-830: Collectibles Manage dropdown. Refactor * TW-830: Collectibles Manage dropdown. Refactor * add main info for nft details screen * fix creators and galleries name * fix comments after review * delete useless code * TW-830: Collectibles Manage dropdown. Fix QA. Loading details by slugs * TW-830: Collectibles Manage dropdown. Fix QA. By design * TW-830: Collectibles Manage dropdown. Fix QA. Scroll to the tabs bar * TW-830: Collectibles Manage dropdown. Fix QA. Refactor * fix after review: add dependencies for hook, update tailwind config * fix margin * TW-830: Collectibles Manage dropdown. Fix QA. 2 decimals for unlettered numbers * TW-830: Collectibles Manage dropdown. Refactor * TW-832: NFT page. Main Info. Fix QA * TW-832: NFT page. Main Info. + 'Send' button * TW-832: NFT page. Main info. Refactor * TW-832: NFT page. Main info. Refactor * TW-760: [epic] NFT update * TW-826: NFT update. Collectibles (#937) * TW-828: NFT update. Collectibles. Grid layout (#935) * TW-826: Collectibles re-design * TW-828: Collectibles grid layout * TW-828: Collectibles grid layout. + Scroll tabsbar into view * TW-828: Collectibles grid layout. ++ Images * TW-864: Collectibles hover effect * TW-828: Collectibles grid layout. Refactor * TW-828: Collectibles grid layout. Refactor * TW-828: Collectibles grid layout. Fix after QA * TW-828: NFT update. Collectibles. Manage dropdown (#936) * TW-826: Collectibles re-design * TW-828: Collectibles grid layout * TW-828: Collectibles grid layout. + Scroll tabsbar into view * TW-828: Collectibles grid layout. ++ Images * TW-864: Collectibles hover effect * TW-828: Collectibles grid layout. Refactor * TW-828: Collectibles grid layout. Refactor * TW-830: Collectibles Manage dropdown. + Detailed grid * TW-830: Collectibles Manage dropdown. + Detailes toggle * TW-830: Collectibles Manage dropdown. + Floor prices * TW-828: Collectibles grid layout. Fix after QA * TW-830: Collectibles Manage dropdown. Fix floor price currency * TW-830: Collectibles Manage dropdown. Refactor * TW-830: Collectibles Manage dropdown. Refactor * TW-830: Collectibles Manage dropdown. Refactor * TW-830: Collectibles Manage dropdown. Fix QA. Loading details by slugs * TW-830: Collectibles Manage dropdown. Fix QA. By design * TW-830: Collectibles Manage dropdown. Fix QA. Scroll to the tabs bar * TW-830: Collectibles Manage dropdown. Fix QA. Refactor * TW-830: Collectibles Manage dropdown. Fix QA. 2 decimals for unlettered numbers * TW-830: Collectibles Manage dropdown. Refactor * TW-832: NFT page. Main info. Refactor * TW-834: NFT page. 'Sell' button * TW-838 Finihes adult nft * TW-838 Fixed linter errors * TW-838 Fixed linter errors * TW-838 Fixed comments * TW-838 Fixed linter errors * TW-834: NFT page. 'Sell' button. + Tx * TW-834: NFT page. 'Sell' button. Refactor * TW-834: NFT page. Main info. 'Sell' button. + Syncing details with interval * TW-830 Fixed comments * TW-832: NFT page re-design. Main info (#931) * TW-826: Collectibles re-design * TW-828: Collectibles grid layout * TW-828: Collectibles grid layout. + Scroll tabsbar into view * TW-828: Collectibles grid layout. ++ Images * TW-864: Collectibles hover effect * TW-828: Collectibles grid layout. Refactor * TW-828: Collectibles grid layout. Refactor * TW-830: Collectibles Manage dropdown. + Detailed grid * TW-830: Collectibles Manage dropdown. + Detailes toggle * TW-830: Collectibles Manage dropdown. + Floor prices * TW-828: Collectibles grid layout. Fix after QA * TW-830: Collectibles Manage dropdown. Fix floor price currency * TW-830: Collectibles Manage dropdown. Refactor * TW-830: Collectibles Manage dropdown. Refactor * TW-830: Collectibles Manage dropdown. Refactor * add main info for nft details screen * fix creators and galleries name * fix comments after review * delete useless code * TW-830: Collectibles Manage dropdown. Fix QA. Loading details by slugs * TW-830: Collectibles Manage dropdown. Fix QA. By design * TW-830: Collectibles Manage dropdown. Fix QA. Scroll to the tabs bar * TW-830: Collectibles Manage dropdown. Fix QA. Refactor * fix after review: add dependencies for hook, update tailwind config * fix margin * TW-830: Collectibles Manage dropdown. Fix QA. 2 decimals for unlettered numbers * TW-830: Collectibles Manage dropdown. Refactor * TW-832: NFT page. Main Info. Fix QA * TW-832: NFT page. Main Info. + 'Send' button * TW-832: NFT page. Main info. Refactor * TW-832: NFT page. Main info. Refactor * TW-832: NFT page. Main info. Refactor --------- Co-authored-by: razbeikov <razbeikov.oleksandr@gmail.com> * TW-834: NFT page. Main info. 'Sell' button. Taking second best offer, when 1st is made by us * TW-834: NFT page. Main info. 'Sell' button. Fix displayed offer * TW-834: NFT page. 'Sell' button. + Operation status section * TW-838 Fixed comments * TW-834: NFT page. 'Sell' button. + Operation error section * TW-838 Fixed comments * TW-838 Fixed comments * TW-834: NFT page. 'Sell' button. Fix QA. Highest order * TW-838 Fixed refresh interval for details * TW-836: NFT page. Attributes & Properties (#946) * TW-836: NFT page. Attributes & Properties * TW-836: NFT page. Attributes & Properties. Correct 'rarity' attribute * TW-836: NFT page. Attributes & Properties. Adjust chips' border-radius * TW-836: NFT page. Attributes & Properties. Refactor * TW-836: NFT page. Attributes & Properties. Refactor * TW-836: NFT page. Attributes & Properties. Refactor * TW-836: NFT page. Attributes & Properties. Fix QA * TW-838 Fixed console * TW-913: NFT update. Tokens Manage dropdown (#949) * TW-913: NFT update. Tokens Manage dropdown * TW-913: NFT update. Tokens Manage dropdown. + Tooltip * TW-913: NFT update. Tokens Manage dropdown. + Hiding 0 balances * TW-913: NFT update. Tokens Manage dropdown. Refactor * TW-913: NFT update. Tokens Manage dropdown. Fix assets list filtering * TW-913: NFT update. Tokens Manage dropdown. Refactor * TW-913: NFT update. Tokens Manage dropdown. Fix QA. Leading assets * TW-838 Fixed adult image on nft page * TW-838 Deleted console.log * TW-842 Handling different NFT formats (#950) * 3d, video, svg animations * queries, packages * music plug * 3d models camera position fix * video loader flickering fix * refactor * useCallback * test bugs fixes * conflicts fix, small refactor * useCallback * conflicts fix * fixed: 1. Music does not play on the NFT; 2. Music starts playing before the loader hides. * fixed: - Animation is interrupted by the loader * refactor: - using google model viewer * remove unnecessary changes * fixed [Firefox] Some NFTs are not loaded * merge conflicts resolve * log * -log * remove deps * Merge branch 'development' into TW-760-epic-nft-update * Merge branch 'development' into TW-760-epic-nft-update * TW-760: Epic NFT update. Fix TS check * TW-994: [QA Epic] NFT update (#956) * TW-994: [QA Epic] NFT update. -- 'three' package * TW-994: [QA Epic] NFT update. Refactor * TW-994: [QA Epic] NFT update. + 'three' package * TW-994: [QA Epic] NFT update. Fix repeated loader on NFT page * TW-994: [QA Epic] NFT update. Fix repeated loader showing * TW-994: [QA Epic] NFT update. Fix cut-off NFT name in page header * TW-994: [QA Epic] NFT update. Fix unblurred glitch * TW-994: [QA Epic] NFT update. Rolled back 'three' version * TW-994: [QA Epic] NFT update. Fix suspense loader appearance * TW-994: [QA Epic] NFT update. Refactor * TW-994: [QA Epic] NFT update. Refactor + Fix 'black circle' images * TW-994: [QA Epic] NFT update. Refactor * TW-994: [QA Epic] NFT update. Refactor * TW-994: [QA Epic] NFT update. Refactor * TW-994: [QA Epic] NFT update. Refactor * TW-994: [QA Epic] NFT update. Fix audio play start * TW-994: [QA Epic] NFT update. Fix NFTs images sources * TW-994: [QA Epic] NFT update. Fix refreshing non-available details * TW-994: [QA Epic] NFT update. + ReduxState.collectibles.adultFlags * TW-994: [QA Epic] NFT update. + Fix loader for non-OBJKT assets * TW-994: [QA Epic] NFT update. Refactor * TW-994: [QA Epic] NFT update. Fix rarity values * TW-994: [QA Epic] NFT update. + Refreshing metadata * TW-994: [QA Epic] NFT update. Fix QA. Attributes words break * TW-994: [QA Epic] NFT update. ++ Refreshing metadata * TW-994: [QA Epic] NFT update. Fix refreshing metadata versioning * Merge branch 'development' into TW-760-epic-nft-update * TW-760: [epic] NFT update. Fix E2E * TW-760: [epic] NFT update. Refactor * TW-760: [epic] NFT update. Refactor * TW-760: [epic] NFT update. Refactor --------- Co-authored-by: razbeikov <razbeikov.oleksandr@gmail.com> Co-authored-by: herkoss <herkodmytro@gmail.com> Co-authored-by: Kornii <starkkor@gmail.com> Co-authored-by: Dmytro Herko <61412282+herkoss@users.noreply.github.com> Co-authored-by: Danyl Mishyn <35381314+lendihop@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://madfish.atlassian.net/browse/TW-832