Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TW-755: AB-Testing for ads acceptance banner #930

Merged
merged 8 commits into from
Jul 12, 2023
Merged

TW-755: AB-Testing for ads acceptance banner #930

merged 8 commits into from
Jul 12, 2023

Conversation

alex-tsx
Copy link
Collaborator

@alex-tsx alex-tsx commented Jul 10, 2023 •
edited
Loading

@alex-tsx alex-tsx temporarily deployed to development July 10, 2023 08:58 — with GitHub Actions Inactive
@alex-tsx alex-tsx self-assigned this Jul 10, 2023
keshan3262
keshan3262 previously approved these changes Jul 10, 2023
View reviewed changes
herkoss
herkoss previously approved these changes Jul 10, 2023
View reviewed changes
src/app/pages/Home/OtherComponents/Tokens/AcceptAdsBanner.tsx Outdated Show resolved Hide resolved
@alex-tsx alex-tsx dismissed stale reviews from herkoss and keshan3262 via fa94c94 July 10, 2023 11:18
@alex-tsx alex-tsx temporarily deployed to development July 10, 2023 11:18 — with GitHub Actions Inactive
keshan3262
keshan3262 previously approved these changes Jul 10, 2023
View reviewed changes
@alex-tsx alex-tsx requested a review from herkoss July 10, 2023 11:41
herkoss
herkoss previously approved these changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@herkoss herkoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ!

@vladvn1905 vladvn1905 temporarily deployed to development July 10, 2023 14:18 — with GitHub Actions Inactive
@alex-tsx alex-tsx dismissed stale reviews from herkoss and keshan3262 via 080daba July 11, 2023 10:47
@alex-tsx alex-tsx temporarily deployed to development July 11, 2023 10:47 — with GitHub Actions Inactive
keshan3262
keshan3262 previously approved these changes Jul 11, 2023
View reviewed changes
herkoss
herkoss previously approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@herkoss herkoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ!

@vladvn1905 vladvn1905 temporarily deployed to development July 11, 2023 12:41 — with GitHub Actions Inactive
@alex-tsx alex-tsx dismissed stale reviews from herkoss and keshan3262 via 2c4db5a July 12, 2023 06:35
@alex-tsx alex-tsx temporarily deployed to development July 12, 2023 06:35 — with GitHub Actions Inactive
keshan3262
keshan3262 previously approved these changes Jul 12, 2023
View reviewed changes
@IrynaKhyzhynska IrynaKhyzhynska temporarily deployed to development July 12, 2023 07:26 — with GitHub Actions Inactive
herkoss
herkoss previously approved these changes Jul 12, 2023
View reviewed changes
@alex-tsx alex-tsx dismissed stale reviews from herkoss and keshan3262 via 6b3d24b July 12, 2023 09:13
@tttt24 tttt24 temporarily deployed to development July 12, 2023 09:34 — with GitHub Actions Inactive
@alex-tsx alex-tsx temporarily deployed to development July 12, 2023 09:42 — with GitHub Actions Inactive
IrynaKhyzhynska
IrynaKhyzhynska approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@IrynaKhyzhynska IrynaKhyzhynska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

firefox done

tttt24
tttt24 approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@tttt24 tttt24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chrome done

@lourenc lourenc merged commit 9d745df into development Jul 12, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keshan3262 keshan3262 keshan3262 approved these changes

@IrynaKhyzhynska IrynaKhyzhynska IrynaKhyzhynska approved these changes

@herkoss herkoss herkoss approved these changes

@tttt24 tttt24 tttt24 approved these changes

Assignees

@alex-tsx alex-tsx

Labels
qa approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@alex-tsx @keshan3262 @IrynaKhyzhynska @herkoss @tttt24 @lourenc @vladvn1905