Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TW-830: Collectibles Manage dropdown #925
TW-830: Collectibles Manage dropdown #925
Changes from 24 commits
af8ba2b
8bc0474
3430d15
65183c2
079102d
8898d8d
a7e1dca
91b219a
fd976af
b47a127
6672f10
531ab18
c19133b
1583a18
3c5b1e4
0757ded
76f3d2f
e14d147
ea9ab54
b4b43fb
5d6a994
be31160
de83dd4
119bff1
4b72ec6
9c7b2f7
5c0f445
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can add in deps
slugs.length
and removechecksum
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those are not the same
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then what is the
checksum
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The kind of dependency, that will only change, when slugs' values change. Not a link to the slugs array, but actual values. That's why I sort them first and then put together in one string.
collectibles
(link to object) may change, thenslugs
(link to object) may change, whilechecksum
will stay the same.