TW-830: Collectibles Manage dropdown #925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svjatoslavtt
reviewed
Jul 4, 2023
svjatoslavtt
previously approved these changes
Jul 5, 2023
Boltman92
reviewed
Jul 5, 2023
Boltman92
reviewed
Jul 5, 2023
Boltman92
previously approved these changes
Jul 5, 2023
svjatoslavtt
approved these changes
Jul 6, 2023
Boltman92
previously approved these changes
Jul 7, 2023
svjatoslavtt
previously approved these changes
Jul 7, 2023
| const { slugs, checksum } = useMemo(() => { | ||
| const slugs = collectibles.map(({ tokenSlug }) => tokenSlug); | ||
|
|
||
| const checksum = slugs.sort().join('+'); |
There was a problem hiding this comment.
you can add in deps slugs.length and remove checksum
There was a problem hiding this comment.
Those are not the same
There was a problem hiding this comment.
Then what is the checksum ?
There was a problem hiding this comment.
The kind of dependency, that will only change, when slugs' values change. Not a link to the slugs array, but actual values. That's why I sort them first and then put together in one string.
collectibles (link to object) may change, then slugs (link to object) may change, while checksum will stay the same.
alex-tsx
requested review from
svjatoslavtt,
Boltman92,
keshan3262,
lendihop and
herkoss
keshan3262
reviewed
Jul 10, 2023
keshan3262
approved these changes
Jul 11, 2023
svjatoslavtt
approved these changes
Jul 11, 2023
IrynaKhyzhynska
temporarily deployed
to
development
GitHub Actions
Inactive
lourenc
pushed a commit
that referenced
this pull request
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://madfish.atlassian.net/browse/TW-830