Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

llama.cpp: update to b4508; fix builds for 10.15 and earlier #27409

Merged
merged 1 commit into from
Jan 19, 2025

Conversation

mascguy
Copy link
Member

@mascguy mascguy commented Jan 17, 2025

Description

@macportsbot
Copy link

Notifying maintainers:
@i0ntempest for port llama.cpp.

@macportsbot macportsbot added maintainer: open Affects an openmaintainer port by: member Created by a member with commit rights labels Jan 17, 2025
@mascguy
Copy link
Member Author

mascguy commented Jan 17, 2025

p.s. Fix verified on 10.13

@mascguy
Copy link
Member Author

mascguy commented Jan 18, 2025

@i0ntempest Zhenfu, any concerns with merging this?

@i0ntempest
Copy link
Member

@i0ntempest Zhenfu, any concerns with merging this?

Yes actually, I don’t want openmp to be disabled globally like this. I’ll take a look but currently I’m busy with something else .

@mascguy
Copy link
Member Author

mascguy commented Jan 18, 2025

@i0ntempest Zhenfu, any concerns with merging this?

Yes actually, I don’t want openmp to be disabled globally like this. I’ll take a look but currently I’m busy with something else .

Well, without either including portgroup mpi - and/or adding dependencies for critical components like libomp, etc - how do you expect OpenMP to work?

@mascguy mascguy changed the title llama.cpp: explicitly disable OpenMP, to fix builds for 10.13 and earlier llama.cpp: fix builds for 10.15 and earlier Jan 18, 2025
@mascguy
Copy link
Member Author

mascguy commented Jan 18, 2025

On a separate note, there's another build failure affecting 10.15. That was just addressed with the latest force-push, along with an update to b4508.

@mascguy mascguy changed the title llama.cpp: fix builds for 10.15 and earlier llama.cpp: update to b4508; fix builds for 10.15 and earlier Jan 18, 2025
- Explicitly disable OpenMP
Fixes: https://trac.macports.org/ticket/71870

- Upstream patch for errno-related build failure on 10.15:
Fixes: https://trac.macports.org/ticket/71880

squash
@i0ntempest
Copy link
Member

@i0ntempest Zhenfu, any concerns with merging this?

Yes actually, I don’t want openmp to be disabled globally like this. I’ll take a look but currently I’m busy with something else .

Well, without either including portgroup mpi - and/or adding dependencies for critical components like libomp, etc - how do you expect OpenMP to work?

I am think about adding compiler.openmp* stuff to this port, but as I said I’ll need a few days. Your update and patch for 10.15 is great tho and can be merged now.

@mascguy
Copy link
Member Author

mascguy commented Jan 19, 2025

Well, without either including portgroup mpi - and/or adding dependencies for critical components like libomp, etc - how do you expect OpenMP to work?

I am think about adding compiler.openmp* stuff to this port, but as I said I’ll need a few days. Your update and patch for 10.15 is great tho and can be merged now.

Sounds good!

@mascguy mascguy merged commit 1304a7d into macports:master Jan 19, 2025
3 checks passed
@mascguy mascguy deleted the mascguy-llama.cpp branch January 20, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
by: member Created by a member with commit rights maintainer: open Affects an openmaintainer port
Development

Successfully merging this pull request may close these issues.

3 participants