Tarun/405 simplify battery monitor #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nagatarun25
requested review from
samparent97,
BlakeFreer,
TylerStAmour,
langei and
CameronBeneteau
as code owners
Nagatarun25
force-pushed
the
tarun/405-simplify-battery-monitor
branch
from
a886ea2 to
f586a7b
Compare
Nagatarun25
force-pushed
the
tarun/405-simplify-battery-monitor
branch
from
c7efb5e to
9435b9a
Compare
…ccordingly. I also Updated the Enum names and only used BmSts enums.
BlakeFreer
requested changes
Mar 9, 2025
firmware/projects/FrontController/control-system/control-system/enums.hpp
Outdated
Show resolved
Hide resolved
firmware/projects/FrontController/control-system/src/battery_monitor.cc
Outdated
Show resolved
Hide resolved
firmware/projects/FrontController/control-system/src/battery_monitor.cc
Outdated
Show resolved
Hide resolved
firmware/projects/FrontController/control-system/test/test_battery_monitor.cc
Outdated
Show resolved
Hide resolved
BlakeFreer
approved these changes
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I combined two state machines into one and I updated the test cases accordingly. I also Updated the Enum names and only used BmSts enums.