Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a simple build and smoke workflow - and package #20

Merged
merged 3 commits into from
Dec 10, 2024
Merged

Add a simple build and smoke workflow - and package #20

merged 3 commits into from
Dec 10, 2024

Conversation

ma595
Copy link
Member

@ma595 ma595 commented Nov 9, 2024 •
edited
Loading

As the title suggests.

Merge #7 first followed by this PR.

Closes #21

@ma595 ma595 self-assigned this Nov 9, 2024
@ma595 ma595 changed the base branch from ruff-reformat to main November 9, 2024 10:58
@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@ma595 ma595 changed the base branch from main to ruff-reformat November 9, 2024 11:23
@ma595 ma595 force-pushed the ruff-reformat branch 3 times, most recently from 87eb819 to 1a78cd9 Compare November 11, 2024 16:52
@ma595 ma595 changed the base branch from ruff-reformat to main November 11, 2024 19:09
@ma595 ma595 changed the base branch from main to ruff-reformat November 11, 2024 19:10
@ma595 ma595 changed the base branch from ruff-reformat to main November 11, 2024 19:10
@ma595 ma595 added the iccs label Nov 11, 2024
@ma595 ma595 changed the title Add a simple build workflow Add a simple build and smoke workflow Nov 11, 2024
surbhigoel77
surbhigoel77 approved these changes Nov 14, 2024
View reviewed changes
Copy link
Collaborator

@surbhigoel77 surbhigoel77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment for a minor add-on comment to the test_forecast.py file. The code runs fine. LGTM

@ma595
Copy link
Member Author

ma595 commented Dec 9, 2024

Left a comment for a minor add-on comment to the test_forecast.py file. The code runs fine. LGTM

As discussed, code does not run locally without explicitly setting export PYTHONPATH=$(pwd)/lib:$PYTHONPATH.

@ma595
Copy link
Member Author

ma595 commented Dec 10, 2024

Left a comment for a minor add-on comment to the test_forecast.py file. The code runs fine. LGTM

As discussed, code does not run locally without explicitly setting export PYTHONPATH=$(pwd)/lib:$PYTHONPATH.

Fixed now by packaging code. Consider updating packaging with poetry or pyproject.toml

@ma595
Copy link
Member Author

ma595 commented Dec 10, 2024

@isaacaka can you please review this?

@ma595 ma595 changed the title Add a simple build and smoke workflow Add a simple build and smoke workflow - and package Dec 10, 2024
@ma595 ma595 merged commit 9574ff0 into main Dec 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@surbhigoel77 surbhigoel77 surbhigoel77 approved these changes

@isaacaka isaacaka Awaiting requested review from isaacaka

Assignees

@ma595 ma595

Labels
iccs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement simple Smoke test of Spinup-NEMO
2 participants
@ma595 @surbhigoel77