Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ArchiveSize and FileSize to parser records #1118

Merged
merged 6 commits into from
Jun 2, 2023

Conversation

stephen-soltesz
Copy link
Contributor

@stephen-soltesz stephen-soltesz commented Jun 2, 2023

This change adds two new fields to the ParseInfo record for all datatypes:

  • ArchiveSize - The original archive size as found in GCS.
  • FileSize - The size of the file data provided to the parser.

To populate the ArchiveSize field, this change adds GetSize() to the TestSource interface and GCSSource implementation.

Part of:


This change is Reviewable

Copy link
Contributor

@cristinaleonr cristinaleonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@stephen-soltesz
Copy link
Contributor Author

Uh oh -- we're doin' it!

Thank you!

@stephen-soltesz stephen-soltesz merged commit df4bdda into main Jun 2, 2023
@stephen-soltesz stephen-soltesz deleted the sandbox-soltesz-parser-size3 branch June 2, 2023 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants