Add etl.Metadata for passing task metadata to parsers #1117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephen-soltesz
changed the title
cristinaleonr
approved these changes
Jun 2, 2023
complete! 1 of 1 approvals obtained
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a new type
etl.Metadataand modifies theetl.Parserinterface to accept this structure instead of the ad-hocmap[string]bigquery.Valuemap.This change eliminates unused fields in the map (i.e.
"attempt"=1), uses standard names for theArchiveURL(rather than "filename", which is ambiguous with the parser's use of ParseInfo.Filename), and eliminates type casts to recover values from thebigquery.Valuetype.While this alters the parser interface, this is a code health improvement, and there should be no users of this interface outside this repo. This change does not alter default behavior.
Part of:
This change is