Add Gardener v2 parser for switch datatype #1059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Initial implementation of the new switch datatype parser. * Fix error handling in parser/switch.go * Fix error handling. * Fill in summary field from samples * Use reflection and add unit tests. * Do not return an error on unknown metrics. This means we just fill the fields we want in the summary, and ignore any extra data. * Update update-schema/update.go to refer to the new SwitchRow struct. * Update switch datatype parser and schema to use int64 * Update dataset/table names in update.go * Add ID to SwitchRow and Broadcast-related fields to the summary. * The "a" field should be lowercase. * Update partition field for the switch table. * Use DATE instead of TIMESTAMP and add CollectionTime to the summary. Also, it's easier to use machine and site if they are not hostnames. * Update comments. * Update regex to account for v1 M-Lab hostnames. * Add accurate estimation of SwitchRow's size. * Update go.mod/go.sum after running go mod tidy. * Remove commented line * Update comment. * Update ID format and variable name. * Update comments. * Add condition to only remove octets.local.tx/rx when needed. * Update switch parser tests. * s/valField/deltaField/ * Update tests. * Updated tests to verify switch discards. * Update tests. * Update comment. * Sort output by timestamp in the switch parser
Pull Request Test Coverage Report for Build 7212
💛 - Coveralls |
stephen-soltesz
approved these changes
Mar 1, 2022
complete! 1 of 1 approvals obtained
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a duplicate of #1044, which was reverted in #1049. The v1 parser has been frozen (#1051) so that we should now be able to merge this new v2 parser without disrupting v1 parsers.
The only change, other than updating the branch from master, was renaming
TestCount->TestTotalin switch.go since the metric's name has been recently changed.This change is