Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new ArchiveSize and FileSize fields #158

Merged
merged 1 commit into from
Jun 6, 2023

Conversation

stephen-soltesz
Copy link
Contributor

@stephen-soltesz stephen-soltesz commented Jun 6, 2023

This change adds the ArchiveSize and FileSize fields to the synthetic, standard-column definition of the static web100 transformation.

The standard column version of the web100 schema is not actively managed by the current etl parser schema. So, these fields cannot be added automatically, as they are for all other datatypes.

Unfortunately, the unified views use UNION ALL across the the ndt7, ndt5, and legacy web100 tables. When the web100 schema is different, it causes the UNION ALL to fail.

This change corrects the schema for web100, but it must be applied manually.


This change is Reviewable

Copy link
Contributor

@cristinaleonr cristinaleonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@stephen-soltesz
Copy link
Contributor Author

Thank you!

@stephen-soltesz stephen-soltesz merged commit 291fd16 into main Jun 6, 2023
@stephen-soltesz stephen-soltesz deleted the sandbox-soltesz-fix-web100-parser branch June 6, 2023 18:16
@stephen-soltesz
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants