Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in the configuration: "enbaleExternalView" #169

Open
aleksejrs opened this issue Sep 21, 2019 · 1 comment
Open

Typo in the configuration: "enbaleExternalView" #169

aleksejrs opened this issue Sep 21, 2019 · 1 comment

Comments

@aleksejrs
Copy link

Current Behavior

"enableExternalView" instead of "enableExternalView":

  • screengrab.conf: enbaleExternalView=true
  • src/core/config.cpp: #define KEY_ENABLE_EXT_VIEWER "enbaleExternalView"
Possible Solution

It could be changed, but maybe old configuration files already contain the typo.

Steps to Reproduce (for bugs)

1.screengrab$ grep -R enbale *

Context

It makes looking at /usr/share/screengrab/screengrab.conf inconvenient.

System Information
  • Package version: commit 33a2e14 (HEAD -> master, origin/master, origin/HEAD)
@agaida
Copy link
Member

agaida commented Jan 20, 2020

~/.config % grep -r enbale screengrab
screengrab/screengrab.conf:enbaleExternalView=true

if we would try to fix it we must read both variables - we would wreck peoples configurations if we don't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants