Skip to content

Commit

Permalink
Fix lint errors, broke coverage requireemnts
Browse files Browse the repository at this point in the history
  • Loading branch information
lwitkowski committed Aug 3, 2024
1 parent 4ab327b commit 20cda87
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 7 deletions.
6 changes: 0 additions & 6 deletions backend/job_fetch_offers.py
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
from datetime import datetime
from scrapy.utils.project import get_project_settings
from twisted.internet import reactor
from scrapy.crawler import CrawlerProcess
from scrapy.crawler import CrawlerRunner

import pprint
from my_logging import *
Expand All @@ -14,7 +12,6 @@
if __name__ == '__main__':
try:
settings = get_project_settings()
runner = CrawlerRunner(settings)
process = CrawlerProcess(settings)

spiders = {
Expand All @@ -27,9 +24,6 @@
spiders[spider_cls] = crawler
process.crawl(crawler)

d = runner.join()
d.addBoth(lambda _: reactor.stop())

process.start() # the script will block here until all crawling jobs are finished

stats_per_spider = {}
Expand Down
2 changes: 1 addition & 1 deletion backend/run_tests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ export PYTHONPATH=$PYTHONPATH':./'
set -e

coverage run --source ./ -m xmlrunner -o ./test-results
coverage report --fail-under=75
coverage report --fail-under=80

0 comments on commit 20cda87

Please sign in to comment.