Librarify #75
Open
Librarify #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not necessarily saying this is good code to merge as it is right now, but I think the implementation details here are useful for starting a structured discussion about what this should look like. And once we settle on something and implement it, we can merge that.
In particular, there are two details to notice. Firstly, there's the
lustre/dev/tools.{run}entrypoint: is this the API we want for specifying hooks in some sort of/test/dev.gleamcode? Possibly, but it definitely deserves discussion. Secondly, there's the architectural point of the build step hook, which serves as a nice problem-case for future hooks: trying to be as noninvasive as possible, you can see I still had to touch many different things to add it, and included some mildly concerning code duplication. We should discuss whether (and how) to change the library architecture with hooks in mind.