fix: address todo comments

crates/lune-std-process/src/lib.rs

@@ -224,17 +224,14 @@ async fn process_spawn(
             .expect("ExitCode receiver was unexpectedly dropped");
     });
 
-    // TODO: Remove the lua errors since we no longer accept stdio options for spawn
     TableBuilder::new(lua)?
         .with_value(
             "stdout",
             ChildProcessReader(
                 stdout_rx
                     .await
                     .expect("Stdout sender unexpectedly dropped")
-                    .ok_or(LuaError::runtime(
-                        "Cannot read from stdout when it is not piped",
-                    ))?,
+                    .unwrap(),
             ),
         )?
         .with_value(
@@ -243,9 +240,7 @@ async fn process_spawn(
                 stderr_rx
                     .await
                     .expect("Stderr sender unexpectedly dropped")
-                    .ok_or(LuaError::runtime(
-                        "Cannot read from stderr when it is not piped",
-                    ))?,
+                    .unwrap(),
             ),
         )?
         .with_value(
@@ -284,10 +279,6 @@ async fn spawn_command(
     let stderr = options.stdio.stderr;
     let stdin = options.stdio.stdin.take();
 
-    // TODO: Have an stdin_kind which the user can supply as piped or not
-    // TODO: Maybe even revamp the stdout/stderr kinds? User should only use
-    // piped when they are sure they want to read the stdout. Currently we default
-    // to piped
     let mut child = options
         .into_command(program, args)
         .stdin(Stdio::piped())

tests/process/spawn/non_blocking.luau

@@ -13,6 +13,6 @@ for _ = 1, SAMPLES do
 	local delta = os.time() - start
 	assert(
 		delta <= 1,
-		`Spawning a child process should not block the main thread, process.spawn took {delta}s to return it should return immediately`
+		`Spawning a child process should not block the main thread, process.spawn took {delta}s to return when it should return immediately`
 	)
 end