calibrate tether upside down #732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpauszek
force-pushed
the
ray/calibrate-tether-upside-down
branch
2 times, most recently
from
32a1538 to
5385da7
Compare
JoepVanlier
approved these changes
Jan 30, 2025
lumicks/pylake/kymo.py
Outdated
| @@ -1123,7 +1122,7 @@ def label(self): | |||
| @dataclass(frozen=True) | |||
| class PositionCalibration: | |||
| unit: PositionUnit = PositionUnit.pixel | |||
| value: float = 1.0 | |||
| factor: float = 1.0 | |||
There was a problem hiding this comment.
I have a mild preference for scale given that one often talks about scale and offset in the context of transforms, but I don't feel very strongly about it.
rpauszek
force-pushed
the
ray/calibrate-tether-upside-down
branch
from
5385da7 to
73effc8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this PR?
Sometimes you want to calibrate your tether with a known orientation but without flipping the kymo. Followup to #726