Skip to content

Commit

Permalink
Replace FileIcon16 with ExternalLinkIcon16 in note preview and note p…
Browse files Browse the repository at this point in the history
…age components, updating the link text to "Open in GitHub" for clarity.
  • Loading branch information
colebemis committed Dec 26, 2024
1 parent 949a761 commit 933b6c1
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
6 changes: 3 additions & 3 deletions src/components/note-preview-card.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import { DropdownMenu } from "./dropdown-menu"
import { IconButton } from "./icon-button"
import {
CopyIcon16,
FileIcon16,
ExternalLinkIcon16,
MoreIcon16,
PinFillIcon16,
PinIcon16,
Expand Down Expand Up @@ -116,13 +116,13 @@ const _NotePreviewCard = React.memo(function NoteCard({ id }: NoteCardProps) {
</DropdownMenu.Item>
<DropdownMenu.Separator />
<DropdownMenu.Item
icon={<FileIcon16 />}
icon={<ExternalLinkIcon16 />}
href={`https://github.com/${githubRepo?.owner}/${githubRepo?.name}/blob/main/${id}.md`}
target="_blank"
rel="noopener noreferrer"
disabled={isSignedOut}
>
Open file in GitHub
Open in GitHub
</DropdownMenu.Item>
<DropdownMenu.Item
icon={<ShareIcon16 />}
Expand Down
6 changes: 3 additions & 3 deletions src/routes/notes_.$.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@ import {
CopyIcon16,
DotIcon8,
EditIcon16,
ExternalLinkIcon16,
EyeIcon16,
FileIcon16,
FullwidthIcon16,
MoreIcon16,
NoteIcon16,
Expand Down Expand Up @@ -413,13 +413,13 @@ function NotePage() {
</DropdownMenu.Item>
<DropdownMenu.Separator />
<DropdownMenu.Item
icon={<FileIcon16 />}
icon={<ExternalLinkIcon16 />}
href={`https://github.com/${githubRepo?.owner}/${githubRepo?.name}/blob/main/${noteId}.md`}
target="_blank"
rel="noopener noreferrer"
disabled={isSignedOut || !note}
>
Open file in GitHub
Open in GitHub
</DropdownMenu.Item>
<DropdownMenu.Item
icon={<ShareIcon16 />}
Expand Down

0 comments on commit 933b6c1

Please sign in to comment.