Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In external concepts table: change column name "label" to "external_id" #20

Open
rue-a opened this issue Sep 20, 2022 · 1 comment
Open
Labels
enhancement New feature or request illogicality Something is not consistent, reasonable, wise, or practical

Comments

@rue-a
Copy link
Contributor

rue-a commented Sep 20, 2022

Links to the external concepts are built by concatenating the uri_prefix from the concept's source with the concept's ID. E.g., concepts from wikidata have the prefix https://www.wikidata.org/wiki/ and an ID in the style of Q<###> (e.g., Q65522654). In the LUCKINet ontology, these (external) IDs are stored in the labels-column, which does not really makes sense, since they are no labels.

As a result, I'd recommend to either rename the column to "external_id" or to add a column named "external_id".

I think the same problem occurs in external classes.

@rue-a
Copy link
Contributor Author

rue-a commented Sep 20, 2022

Thinking about this, this is a chance to reduce some complexity. Instead of adding a column "external_id", which then has to be combined with the according uri_prefix, we could simply add a column "url" or "iri" that holds the URL (or IRI) of the according external concept.

I think that would make the process of adding an external concept less error-prone, since one then does not have to disentangle the URL into prefix and external_id, which - in the end - get concatenated again. When simply copy-pasting the external concept's URL it is hard to miss a symbol or something.

Also that would possibly make the uri_prefix column we added because of Issue Enforce value for homepage in sources obsolete, therefore making the package easier to use (understand).

@rue-a rue-a added bug Something isn't working enhancement New feature or request illogicality Something is not consistent, reasonable, wise, or practical and removed bug Something isn't working labels Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request illogicality Something is not consistent, reasonable, wise, or practical
Projects
None yet
Development

No branches or pull requests

1 participant