Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't compare vision penalties against those ch doesn't have #750

Merged
merged 2 commits into from
Sep 3, 2024

Conversation

jdevnull
Copy link
Contributor

@jdevnull jdevnull commented Sep 2, 2024

Vision penalties are calculated in two steps:

  1. Penalties for normal, LL, and thermo are summed up. This occurs regardless of whether you actually have the vision type. If you don't have the natural version of LL or thermo, then their respective calculations default to artificial versions.
  2. If you have a vision type and its penalty is better than the other vision types, then you get that penalty.

But, (2) wasn't avoiding penalty comparisons against vision types the character doesn't have. If the penalty for an artificial vision type is lower, when you don't have that vision type, then you can end with a higher normal vision penalty. This PR provides a solution.

This addresses: https://discord.com/channels/564618629467996170/788953927269613608/1280229594561253504

@jdevnull
Copy link
Contributor Author

jdevnull commented Sep 2, 2024

Oops, logic is wrong, let me try that again...

@luciensadi luciensadi merged commit dbe571d into luciensadi:master Sep 3, 2024
2 checks passed
@luciensadi
Copy link
Owner

Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants