Don't compare vision penalties against those ch doesn't have #750
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vision penalties are calculated in two steps:
But, (2) wasn't avoiding penalty comparisons against vision types the character doesn't have. If the penalty for an artificial vision type is lower, when you don't have that vision type, then you can end with a higher normal vision penalty. This PR provides a solution.
This addresses: https://discord.com/channels/564618629467996170/788953927269613608/1280229594561253504