Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On NPC death, leave up to one round in their firearm #749

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

jdevnull
Copy link
Contributor

When ammo dropped in NPC firearms, players could learn what type of ammo was being fired at them with an in-character mechanism, helping them understand why some enemies are more dangerous than others. Allowing up to one round to remain in dropped NPC firearms restores this mechanism.

Technically, this restores some ability to farm ammo, but at no more than one round per firearm, it would be... inefficient.

Copy link
Owner

@luciensadi luciensadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. Requesting one change for maintainability down the line.

src/fight.cpp Outdated Show resolved Hide resolved
@luciensadi luciensadi merged commit f7d52a8 into luciensadi:master Aug 27, 2024
2 checks passed
@luciensadi
Copy link
Owner

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants