Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LDEV-5230 internalRequest should not create sessions #2464

Merged
merged 1 commit into from
Jan 1, 2025
Merged

LDEV-5230 internalRequest should not create sessions #2464

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions core/src/main/java/lucee/runtime/functions/system/InternalRequest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ else if (body != null) {
_pc.flush();
// cookie = _pc.cookieScope().duplicate(false);
request = _pc.requestScope().duplicate(false);
session = sessionEnabled(_pc) ? _pc.sessionScope().duplicate(false) : null;
session = _pc.hasCFSession() ? _pc.sessionScope().duplicate(false) : null;
exeTime = System.currentTimeMillis() - pc.getStartTime();
// debugging=_pc.getDebugger().getDebuggingData(_pc).duplicate(false);

Expand Down Expand Up @@ -244,12 +244,6 @@ private static Struct toStruct(Object obj) throws PageException {
return data;
}

private static boolean sessionEnabled(PageContextImpl pc) {
ApplicationContext ac = pc.getApplicationContext();
if (ac == null) return false;// this test properly is not necessary
return ac.hasName() && ac.isSetSessionManagement();
}

private static void fillForm(PageContextImpl _pc, Struct src, Charset charset) throws PageException {
if (src == null) return;

Expand Down
Loading