Skip to content

Issues: lucamarini22/marine-anomaly-detection

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

11 Open 6 Closed
11 Open 6 Closed
Author
Filter by author
Loading
Label
Filter by label
Loading
Use alt + click/return to exclude labels
or ⇧ + click/return for logical OR
Projects
Filter by project
Loading
Milestones
Filter by milestone
Loading
Assignee
Filter by who’s assigned
Sort
Sort by
Newest Oldest Most commented Least commented Recently updated Least recently updated Best match
Most reactions
👍 👎 😄 🎉 😕 ❤️ 🚀 👀

Issues list

Is this published?
#40 opened Mar 21, 2024 by robmarkcole
1
nice-to-add colored output for logs
#37 opened Oct 5, 2023 by lucamarini22
1
One thing to think about in general maybe if you want your code at all to be usable with other datasets. Because it seems to me you are writing it in a way that will make it extremely difficult to ever use any other dataset? 🤔
#28 opened Jul 16, 2023 by lucamarini22
Turbid Water changes too, but yeah I need to make a script to get this numbers automatically when running training instead of getting that beforehand
#27 opened Jul 16, 2023 by lucamarini22
I would suggest you start using cfg files and just have a debug.cfg etc. Right now it seems you are changing default values in your code all the time. This is very dangerous as you may introduce errors or forget to change things back. What I would suggest is:
#26 opened Jul 16, 2023 by lucamarini22
open todo
#18 opened Apr 18, 2023 by lucamarini22
If I was you, I would merge individual readme files into one big on the root. Otherwise, people will not find it or might discard your repo initially thinking that there are not enough docs etc.
#14 opened Apr 3, 2023 by lucamarini22
you are not dividing, not sure if intentional? if so, would remove to avoid later being confused whether you meant to divide
#13 opened Apr 3, 2023 by lucamarini22
This is quite a large file with a lot of different functions some which don't have to be in this class since they are static. would consider moving some of out the class
#8 opened Mar 31, 2023 by lucamarini22
instead of having different arg parse in files may be nicer to have that collected in some other file? you probably need it in any your scripts?
#7 opened Mar 31, 2023 by lucamarini22
Some comments here and there. In general, I would try to break up your file structure a bit. If I read your filenames it is pretty hard to understand how things interact and in most files you have a lot of static functions, so it seems like a file is not something that combines things that have one clear purpose but just a bunch of thrown together functions. Would try to divide by purpose / activity into subfolders like : imageprocessing, io, datastructure or something like that with dedicated files for specific things
#6 opened Mar 31, 2023 by lucamarini22
ProTip! Adding no:label will show everything without a label.