Fix write_float edge case, which crashes NJOY #306
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a strange edge case in
write_float
wherebut
Likely because the string interpolation
f"{x:13.6e}"
is rounding up to1.000000e+00
, and it isn't caught as a case in the function.This was giving an annoying error from NJOY
Fortran runtime error: Bad value during floating point read
, where these strings end up in generated pendf files, and are unable to be read by NJOY.