Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Const correct Thread class #15741

Merged
merged 3 commits into from
Feb 9, 2025
Merged

Const correct Thread class #15741

merged 3 commits into from
Feb 9, 2025

Conversation

wrrrzr
Copy link
Contributor

@wrrrzr wrrrzr commented Feb 1, 2025

This pr makes more const correctly class Thread
This PR is Ready for Review.

@Zughy Zughy added Maintenance Tasks to keep the codebase and related parts in order, including architectural improvements Code quality labels Feb 1, 2025
appgurueu
appgurueu reviewed Feb 3, 2025
View reviewed changes
appgurueu
appgurueu reviewed Feb 3, 2025
View reviewed changes
Copy link
Contributor

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest are getters so they should be fine.

sfan5
sfan5 reviewed Feb 3, 2025
View reviewed changes
@sfan5 sfan5 added the Action / change needed Code still needs changes (PR) / more information requested (Issues) label Feb 3, 2025
@Zughy Zughy removed the Action / change needed Code still needs changes (PR) / more information requested (Issues) label Feb 4, 2025
@sfan5 sfan5 changed the title Const correctly Thread Const correct Thread class Feb 4, 2025
@sfan5 sfan5 merged commit 045951b into luanti-org:master Feb 9, 2025
17 checks passed
@wrrrzr wrrrzr deleted the const_thread branch February 9, 2025 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@appgurueu appgurueu appgurueu approved these changes

@sfan5 sfan5 sfan5 approved these changes

Assignees
No one assigned
Labels
Code quality Maintenance Tasks to keep the codebase and related parts in order, including architectural improvements >= Two approvals ✅ ✅
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wrrrzr @sfan5 @appgurueu @Zughy