Skip to content

Commit

Permalink
Merge pull request #5 from ltfschoen/feature/csv-generator
Browse files Browse the repository at this point in the history
Feature/csv generator
  • Loading branch information
ltfschoen authored Mar 7, 2017
2 parents be2e739 + 40d8cb0 commit 260a5cd
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 3 deletions.
5 changes: 4 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

# Screenshot

![alt tag](https://raw.githubusercontent.com/ltfschoen/rails_csv_app/master/screenshot2.png)
![alt tag](https://raw.githubusercontent.com/ltfschoen/rails_csv_app/master/screenshot3.png)

---

Expand Down Expand Up @@ -42,6 +42,8 @@
* [X] - Use AJAX and apply basic filters on table so data updated without refreshing whole page.
* [X] - Use Sass instead of CSS
* [X] - Add Bootstrap 4 styling for buttons and tables and Responsive grid
* [X] - Generate Fake CSV Data
* [X] - Add Images using LorelPixel
* [ ] - Switch front-end to React.js or Angular.js instead of jQuery
* [ ] - Add more Unit Tests

Expand Down Expand Up @@ -305,3 +307,4 @@ written for Rails 3 back in 2010, to make it run without error:
`faked_csv -i fake_csv_config.csv.json -o products.csv`
* Insert the Labels at the top of the generated file, i.e.
`uid,name,quantity,price,comments,released_at`
* Convert image to display correctly
6 changes: 4 additions & 2 deletions app/views/products/_products.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
<th><%= sortable "name", "Name" %></th>
<th><%= sortable "price", "Price" %></th>
<th><%= sortable "quantity", "Quantity" %></th>
<th><%= sortable "comments", "Comments" %></th>
<th><%= sortable "comments", "Image" %></th>
<th><%= sortable "released_at", "Released" %></th>
</tr>
</thead>
Expand All @@ -23,7 +23,9 @@
<td class="text-primary"><%= product.name %></td>
<td class="text-primary price"><%= number_to_currency(product.price) %></td>
<td class="text-primary"><%= product.quantity %></td>
<td class="text-muted"><%= product.comments %></td>
<td class="text-muted">
<%= image_tag product.comments %>
</td>
<td class="text-muted"><%= product.released_at.strftime("%B %e, %Y") %></td>
</tr>
</tbody>
Expand Down
Binary file added screenshot3.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit 260a5cd

Please sign in to comment.