DM-49036: Switch to new syntax for generics #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the new syntax added in Python 3.12 for generics. This results in better typing in mypy, which required a few added casts because the typing of metrics publishers is dynamic and somewhat strange. Sphinx unfortunately has bugs generating documentation for generics when `from __future__ import annotations` is present, so remove that line from several modules so that the documentation will generate properly. autodoc_pydantic is unfortunately very buggy when used with `Annotated`, which required several additional ignore rules and probably results in poor documentation for some Pydantic models.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the new syntax added in Python 3.12 for generics. This results in better typing in mypy, which required a few added casts because the typing of metrics publishers is dynamic and somewhat strange.
Sphinx unfortunately has bugs generating documentation for generics when
from __future__ import annotationsis present, so remove that line from several modules so that the documentation will generate properly.autodoc_pydantic is unfortunately very buggy when used with
Annotated, which required several additional ignore rules and probably results in poor documentation for some Pydantic models.