Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add epo-react-lib #114

Merged
merged 9 commits into from
Jul 22, 2024
Merged

feat: add epo-react-lib #114

merged 9 commits into from
Jul 22, 2024

Conversation

alexgoff
Copy link
Contributor

@alexgoff alexgoff commented Jul 17, 2024 •
edited
Loading

Summary of changes:

  • Replaced icons with library equivalents except in cases where an icon is unique to Skyviewer
  • Replaced CSS tokens with library equivalents
  • Replaced all SASS color variables with CSS variables
  • Replaced CSS reset + base styles with library equivalent
  • Replaced MixedLink, ExternalLink, Image, ResponsiveImage, and Slider with library equivalents
  • Replaced Button and Buttonish with library equivalents where possible (almost anywhere that isn't an icon button)
  • Removed commented code and unused imports in any files worked in
  • Replaced SASS fontface with next/font
  • updated styled-components, i18next, and react-i18next for library install
  • linting

@alexgoff alexgoff self-assigned this Jul 17, 2024
@github-actions GitHub Actions
Copy link

A preview of this PR will be available at https://107installlibraries-dot-skyviewer-client-dot-skyviewer.uw.r.appspot.com until the request is closed.

1 similar comment
@github-actions GitHub Actions
Copy link

A preview of this PR will be available at https://107installlibraries-dot-skyviewer-client-dot-skyviewer.uw.r.appspot.com until the request is closed.

@alexgoff alexgoff force-pushed the 107-install-libraries branch from c442418 to 400684e Compare July 17, 2024 23:03
@github-actions GitHub Actions
Copy link

A preview of this PR will be available at https://107installlibraries-dot-skyviewer-client-dot-skyviewer.uw.r.appspot.com until the request is closed.

2 similar comments
@github-actions GitHub Actions
Copy link

A preview of this PR will be available at https://107installlibraries-dot-skyviewer-client-dot-skyviewer.uw.r.appspot.com until the request is closed.

@github-actions GitHub Actions
Copy link

A preview of this PR will be available at https://107installlibraries-dot-skyviewer-client-dot-skyviewer.uw.r.appspot.com until the request is closed.

@alexgoff alexgoff marked this pull request as ready for review July 19, 2024 17:06
@alexgoff alexgoff requested a review from ericdrosas87 July 19, 2024 17:06
@alexgoff alexgoff force-pushed the 107-install-libraries branch from 3117a02 to ff4102d Compare July 22, 2024 23:16
@github-actions GitHub Actions
Copy link

A preview of this PR will be available at https://107installlibraries-dot-skyviewer-client-dot-skyviewer.uw.r.appspot.com until the request is closed.

@alexgoff alexgoff merged commit 6ce0977 into develop Jul 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericdrosas87 ericdrosas87 ericdrosas87 approved these changes

Assignees

@alexgoff alexgoff

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexgoff @ericdrosas87