Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ibex,tracer] Uniquify trace log with module hierarchy #2254

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Razer6
Copy link
Member

@Razer6 Razer6 commented Feb 14, 2025

In case of having multiple Ibexes, this caues a conflict in openening the same filename from different instances. Add the unique module hierarchy into the filename.

In case of having multiple Ibexes, this caues a conflict in openening
the same filename from different instances. Add the unique module
hierarchy into the filename.

Signed-off-by: Robert Schilling <rschilling@rivosinc.com>
Copy link
Member

@nasahlpa nasahlpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know if the trace log is automatically parsed by some other tool where we also should adapt the path after your change? If not, LGTM.

@Razer6
Copy link
Member Author

Razer6 commented Feb 14, 2025

Not that I am aware of.

@Razer6
Copy link
Member Author

Razer6 commented Feb 14, 2025

@GregAC or anyone with access, can you look into the failing CI?

@andreaskurth
Copy link
Contributor

Do you know if the trace log is automatically parsed by some other tool where we also should adapt the path after your change? If not, LGTM.

Yes, it gets parsed by DV, and that's why CI checks fail. The newly added _%m suffix will have to be added to dv/uvm/core_ibex/scripts/run_rtl.py as well as to documentation.

Before proceeding with that, I have a question for @Razer6: Is the hart ID, which gets appended to the file name, not sufficient for separating the trace log files? That is, do you have multiple harts with the same ID?

@Razer6
Copy link
Member Author

Razer6 commented Feb 17, 2025

Before proceeding with that, I have a question for @Razer6: Is the hart ID, which gets appended to the file name, not sufficient for separating the trace log files? That is, do you have multiple harts with the same ID?

We have multiple Ibexes in the system. These are independent systems, thus the RV spec specifies all of them having hart id 0. Hart ID only becomes different, if let's say, Ibex has multiple harts within itself.

@andreaskurth
Copy link
Contributor

We have multiple Ibexes in the system. These are independent systems, thus the RV spec specifies all of them having hart id 0. Hart ID only becomes different, if let's say, Ibex has multiple harts within itself.

RISC-V just specifies that "at least one hart must have a hart ID of zero" and that "hart IDs must be unique within the execution environment." So this change would address the case when there are actually multiple disjoint execution environments in the same RTL simulation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants